Upgrade auto-installed Node to latest LTS and suppress some npm install errors
#8956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheriks
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
joheriks
force-pushed
the
joherks/8741-npm-install-errors
branch
from
612fe5a
to
1dd3c20
Compare
joheriks
changed the title
npm install errorsnpm install errors
joheriks
force-pushed
the
joherks/8741-npm-install-errors
branch
from
ecbd116
to
4d95ba4
Compare
added 6 commits
September 8, 2020 14:58
…tifact` to ensure same node is used to run npm and package install scripts
This reverts commit 47d541c.
…nt LTS) in docstrings and tests
joheriks
force-pushed
the
joherks/8741-npm-install-errors
branch
from
4d95ba4
to
fed5e81
Compare
|
SonarQube analysis reported 7 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
denis-anisimov
approved these changes
Sep 9, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Addnode-gypas a dev dependency (required for native compilation offsevents1 on macOS). Note thatfsevents1 is deprecated and is only required forchokidar2 (also deprecated), which is a requirement ofwebpack4 but is not used at runtime (chokidar3 is included). Hence, fix 2 is only cosmetic: it prevents the unsightlyspawn node-gyp EACCESerrors, but on the flip side the native compilation increases thenpm installtime compared to the install script failing. All for no good reason.--scripts-prepend-node-artifact=trueto Node install to ensure that the same node executable is used for running npm and package install scripts.Related to #8741.