Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement lit template parser for limited template formats which extends LitTemplate element #8979

Merged
merged 12 commits into from Sep 11, 2020
Merged

Implement lit template parser for limited template formats which extends LitTemplate element #8979

merged 12 commits into from Sep 11, 2020

Conversation

denis-anisimov
Copy link
Contributor

Fixes #8966

@joheriks joheriks self-requested a review September 10, 2020 07:22
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.1.0 labels Sep 10, 2020
@vaadin-bot vaadin-bot added +0.1.0 and removed +1.0.0 labels Sep 10, 2020
vaadin-bot
vaadin-bot reviewed Sep 11, 2020
View reviewed changes
flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/BundleParser.java
if (name.contains(FLOW_NPM_PACKAGE_NAME) ||
name.contains(DEFAULT_FLOW_RESOURCES_FOLDER)) {
if (name.contains(FLOW_NPM_PACKAGE_NAME)
|| name.contains(DEAULT_FLOW_RESOURCES_FOLDER)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Remove this use of "DEAULT_FLOW_RESOURCES_FOLDER"; it is deprecated. rule

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 8 issues

  • CRITICAL 1 critical
  • MAJOR 5 major
  • MINOR 2 minor

Watch the comments in this conversation to review them.

4 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL BundleParser.java#L205: Define a constant instead of duplicating this literal "The parsed template document was {}" 3 times. rule
  2. MAJOR LitTemplateDataAnalyzer.java#L1: Class com.vaadin.flow.component.littemplate.LitTemplateDataAnalyzer defines non-transient non-serializable instance field parser rule
  3. MAJOR IdCollector.java#L138: Call "tagName.isPresent()" before accessing the value. rule
  4. MINOR LitTemplate.java#L106: Remove this method to simply inherit it. rule

@denis-anisimov
Copy link
Contributor Author

Implement lit template parser for limited template formats which extends LitTemplate element

Fixes #8966

@denis-anisimov denis-anisimov merged commit 721758d into master Sep 11, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Sep 11, 2020
@denis-anisimov denis-anisimov deleted the 8966-lit-template-parser branch September 11, 2020 10:17
@vaadin-bot vaadin-bot added +1.0.0 and removed +0.1.0 labels Oct 20, 2020
caalador pushed a commit that referenced this pull request Jan 26, 2021
@caalador
Implement lit template parser for limited template formats which exte…
04d8831 
…nds LitTemplate element (#8979)

Implement lit template parser for limited template formats which extends LitTemplate element

Fixes #8966
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java
#	flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/BundleParser.java
#	flow-server/src/test/resources/META-INF/VAADIN/config/stats.json
caalador pushed a commit that referenced this pull request Jan 27, 2021
@caalador
Implement lit template parser for limited template formats which exte…
cc835f6 
…nds LitTemplate element (#8979)

Implement lit template parser for limited template formats which extends LitTemplate element

Fixes #8966
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java
#	flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/BundleParser.java
#	flow-server/src/test/resources/META-INF/VAADIN/config/stats.json
caalador pushed a commit that referenced this pull request Jan 29, 2021
@caalador
Implement lit template parser for limited template formats which exte…
7f7b148 
…nds LitTemplate element (#8979)

Implement lit template parser for limited template formats which extends LitTemplate element

Fixes #8966
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java
#	flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/BundleParser.java
#	flow-server/src/test/resources/META-INF/VAADIN/config/stats.json
caalador pushed a commit that referenced this pull request Feb 2, 2021
@caalador
Implement lit template parser for limited template formats which exte…
3d07648 
…nds LitTemplate element (#8979)

Implement lit template parser for limited template formats which extends LitTemplate element

Fixes #8966
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java
#	flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/BundleParser.java
#	flow-server/src/test/resources/META-INF/VAADIN/config/stats.json
pleku pushed a commit that referenced this pull request Feb 2, 2021
@pleku
Implement lit template parser for limited template formats which exte…
ede3f83 
…nds LitTemplate element (#8979)

Implement lit template parser for limited template formats which extends LitTemplate element

Fixes #8966
# Conflicts:
#	flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java
#	flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/BundleParser.java
#	flow-server/src/test/resources/META-INF/VAADIN/config/stats.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-bot vaadin-bot vaadin-bot left review comments

@joheriks joheriks joheriks approved these changes

Assignees
No one assigned
Labels
+1.0.0
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement template parser for Lit templates
3 participants
@denis-anisimov @vaadin-bot @joheriks