Read template attributes as properties #8988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-anisimov
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
denis-anisimov
force-pushed
the
8974-template-props
branch
from
6df8be6
to
e44fb27
Compare
joheriks
suggested changes
Sep 11, 2020
.../src/main/java/com/vaadin/flow/component/template/internal/InjectableElementInitializer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/vaadin/flow/component/template/internal/InjectableElementInitializer.java
Outdated
Show resolved
Hide resolved
.../src/main/java/com/vaadin/flow/component/template/internal/InjectableElementInitializer.java
Outdated
Show resolved
Hide resolved
added 11 commits
September 11, 2020 19:18
Conflicts: flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/BundleParser.java
Implement initialization for Lit templates Check the attribute value for dynamic declaration
denis-anisimov
force-pushed
the
8974-template-props
branch
from
49acd2e
to
ae1716a
Compare
added 7 commits
September 11, 2020 20:20
* Correct parser usage in CTORs * Use boolean attribute * Add headers for files
joheriks
approved these changes
Sep 14, 2020
|
SonarQube analysis reported 4 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Sep 14, 2020
caalador
pushed a commit
that referenced
this pull request
Jan 27, 2021
Read template attributes as properties Fixes #8974 # Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/TemplateDataAnalyzer.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/TemplateInitializer.java # flow-server/src/test/java/com/vaadin/flow/component/polymertemplate/PolymerTemplateTest.java # flow-tests/test-root-context/frontend/AttributeTemplate.js # flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/TemplateAttributeView.java # flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/template/TemplateAttributeIT.java
caalador
pushed a commit
that referenced
this pull request
Jan 29, 2021
Read template attributes as properties Fixes #8974 # Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/TemplateDataAnalyzer.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/TemplateInitializer.java # flow-server/src/test/java/com/vaadin/flow/component/polymertemplate/PolymerTemplateTest.java # flow-tests/test-root-context/frontend/AttributeTemplate.js # flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/TemplateAttributeView.java # flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/template/TemplateAttributeIT.java
caalador
pushed a commit
that referenced
this pull request
Feb 2, 2021
Read template attributes as properties Fixes #8974 # Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/TemplateDataAnalyzer.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/TemplateInitializer.java # flow-server/src/test/java/com/vaadin/flow/component/polymertemplate/PolymerTemplateTest.java # flow-tests/test-root-context/frontend/AttributeTemplate.js # flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/TemplateAttributeView.java # flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/template/TemplateAttributeIT.java
pleku
pushed a commit
that referenced
this pull request
Feb 2, 2021
Read template attributes as properties Fixes #8974 # Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/littemplate/LitTemplateDataAnalyzer.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/TemplateDataAnalyzer.java # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/TemplateInitializer.java # flow-server/src/test/java/com/vaadin/flow/component/polymertemplate/PolymerTemplateTest.java # flow-tests/test-root-context/frontend/AttributeTemplate.js # flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/TemplateAttributeView.java # flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/template/TemplateAttributeIT.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8974