fix: surround 404 check with spaces #8997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`checkLogsForErrors` checks if the message contains `404`, but it will match if the sequence is part of a number.
caalador
added this to WIP
in OLD Vaadin Flow bugs & maintenance (Vaadin 10+)
via automation
caalador
approved these changes
Sep 11, 2020
OLD Vaadin Flow bugs & maintenance (Vaadin 10+)
automation
moved this from WIP
to Closed
Sep 11, 2020
caalador
pushed a commit
that referenced
this pull request
Sep 11, 2020
`checkLogsForErrors` checks if the message contains `404`, but it will match if the sequence is part of a number. # Conflicts: # flow-test-util/src/main/java/com/vaadin/flow/testutil/TestBenchHelpers.java
caalador
pushed a commit
that referenced
this pull request
Sep 11, 2020
`checkLogsForErrors` checks if the message contains `404`, but it will match if the sequence is part of a number.
joheriks
pushed a commit
that referenced
this pull request
Sep 11, 2020
`checkLogsForErrors` checks if the message contains `404`, but it will match if the sequence is part of a number. # Conflicts: # flow-test-util/src/main/java/com/vaadin/flow/testutil/TestBenchHelpers.java
caalador
pushed a commit
that referenced
this pull request
Sep 16, 2020
`checkLogsForErrors` checks if the message contains `404`, but it will match if the sequence is part of a number.
pleku
pushed a commit
that referenced
this pull request
Sep 17, 2020
`checkLogsForErrors` checks if the message contains `404`, but it will match if the sequence is part of a number. # Conflicts: # flow-test-util/src/main/java/com/vaadin/flow/testutil/TestBenchHelpers.java
mshabarov
pushed a commit
that referenced
this pull request
Sep 17, 2020
`checkLogsForErrors` checks if the message contains `404`, but it will match if the sequence is part of a number. # Conflicts: # flow-test-util/src/main/java/com/vaadin/flow/testutil/TestBenchHelpers.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkLogsForErrorschecks if the message contains404, but it will match if the sequence is part of a number.This build for Grid is an example of such case.