Read text for template element #9008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joheriks
suggested changes
Sep 15, 2020
flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java
Outdated
Show resolved
Hide resolved
...n/java/com/vaadin/flow/component/template/internal/AbstractInjectableElementInitializer.java
Outdated
Show resolved
Hide resolved
flow-tests/test-root-context/src/test/java/com/vaadin/flow/uitest/ui/template/ChildOrderIT.java
Show resolved
Hide resolved
denis-anisimov
force-pushed
the
8975-text-template-element
branch
from
a0174e5
to
24701f0
Compare
added 8 commits
September 17, 2020 12:47
denis-anisimov
force-pushed
the
8975-text-template-element
branch
from
30a4c45
to
6eeb9aa
Compare
vaadin-bot
reviewed
Sep 17, 2020
flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java
Show resolved
Hide resolved
|
SonarQube analysis reported 1 issue
Watch the comments in this conversation to review them. |
joheriks
approved these changes
Sep 17, 2020
OLD Vaadin Flow ongoing work (Vaadin 10+)
automation
moved this from Iteration Reviews
to Done - pending release
Sep 17, 2020
caalador
pushed a commit
that referenced
this pull request
Jan 27, 2021
* Read text content as an attribute data * Add unit tests for template element set text * Add IT for template element set text * Update IT after change for reading text * Improve code a bit based on review * Add missed tag for the component * Remove extra symbol * Add lost lines after merge # Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java
caalador
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Read text content as an attribute data * Add unit tests for template element set text * Add IT for template element set text * Update IT after change for reading text * Improve code a bit based on review * Add missed tag for the component * Remove extra symbol * Add lost lines after merge # Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java
caalador
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Read text content as an attribute data * Add unit tests for template element set text * Add IT for template element set text * Update IT after change for reading text * Improve code a bit based on review * Add missed tag for the component * Remove extra symbol * Add lost lines after merge # Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java
pleku
pushed a commit
that referenced
this pull request
Feb 2, 2021
* Read text content as an attribute data * Add unit tests for template element set text * Add IT for template element set text * Update IT after change for reading text * Improve code a bit based on review * Add missed tag for the component * Remove extra symbol * Add lost lines after merge # Conflicts: # flow-server/src/main/java/com/vaadin/flow/component/polymertemplate/IdCollector.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8975