Set display:none in addition to hidden attribute when hiding elements inside a shadow root
#9026
Conversation
joheriks
added this to Iteration Reviews
in OLD Vaadin Flow ongoing work (Vaadin 10+)
via automation
joheriks
force-pushed
the
joheriks/8256-template-visibility-in-shadow-root
branch
from
a3eedc8
to
b55fe75
Compare
There was a problem hiding this comment.
There are some GWT unit tests for visibility.
Please review them whether they need to be extended.
Some tests are for the visibility feature (bind/unbind) mostly.
But other tests are for hidden attribute behavior.
E.g.
testBindHiddenElement_stateNodeIsVisible_elementStaysHidden
testBindHiddenElement_stateNodeChangesVisibility_elementStaysHidden,
testBindNotHiddenElement_stateNodeChangesVisibility_elementIsNotHidden, ....
flow-server/src/main/java/com/vaadin/flow/internal/nodefeature/NodeProperties.java
Show resolved
Hide resolved
flow-tests/test-root-context/frontend/lit/lit-template-inner.js
Outdated
Show resolved
Hide resolved
…hidden attribute present (not in shadowroot)
I added an additional assertion that |
| * the element to test | ||
| * @return whether the element is in a shadow root | ||
| */ | ||
| public static native boolean isInShadowRoot(Element element) |
There was a problem hiding this comment.
I added an additional assertion that style={display:none} is not added in existing tests checking attribute hidden. This protects against regressions where it would be added unncessarily (for elements not in shadow root). Not sure how to set up a GWT test for the shadow root case.
I think we need more GWT tests for this.
It's possible to emulate code with shadow root with this code or change one.
You may create Elements hierarchy so that one element in the hierarchy returns '[object ShadowRoot]'.
Just fake it: create a fake toString method and return this string from it.
Another way could be reimplement this method a bit so that it doesn't use toString but check whether an element has a parent whose shadowRoot property is set to the element.
Then it's also possible to fake shadowRoot.
We have quite many tests like that which fakes elements.
See e.g. GwtBasicElementBinderTest: initPolymer , addShadowRootElement, etc.
With mocking/faking it should be possible to write the same tests for display style as we already have for hidden.
There was a problem hiding this comment.
Ok, thanks for the hints. Added two unit tests.
denis-anisimov
deleted the
joheriks/8256-template-visibility-in-shadow-root
branch
Fixes #8256.