[OSGi] - Cleanup BudleActivator and Service registration, Update bnd and osgi deps #9361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stbischof
commented
Nov 10, 2020
•
stbischof
commented
- cleanup BudleActivator
- cleanup Service registration
- use declarative services
- update bnd
- update osgi deps
- base it-test
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
stbischof
changed the title
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
@denis-anisimov this commit 06ed6c7 fixes the errors. iIadded some more OSGi-related atomic commits. Most removes BudleActivator and/or bundleContect::registerService. I not uses declarative Services via @component |
Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
stbischof
force-pushed
the
osgi-master-fix
branch
from
2ec425e
to
173f672
Compare
stbischof
changed the title
vaadin-bot
reviewed
Nov 10, 2020
| public VaadinBundleTracker(BundleContext context) { | ||
| super(context, Bundle.ACTIVE | Bundle.RESOLVED, null); | ||
| flowServerBundle = context.getBundle(); | ||
| open(); |
There was a problem hiding this comment.
vaadin-bot
reviewed
Nov 10, 2020
| @@ -145,7 +162,7 @@ public Bundle addingBundle(Bundle bundle, BundleEvent event) { | |||
|
|
|||
| private void registerPushResources(Bundle pushBundle) { | |||
| Hashtable<String, Object> properties = new Hashtable<>(); | |||
There was a problem hiding this comment.
vaadin-bot
reviewed
Nov 10, 2020
| * @since | ||
| */ | ||
| @org.osgi.service.component.annotations.Component(immediate = true) | ||
| public class PolymerPublishedEventRpcHandler | ||
| implements DeprecatedPolymerPublishedEventHandler { |
There was a problem hiding this comment.
|
SonarQube analysis reported 14 issues
Watch the comments in this conversation to review them. Top 10 extra issuesNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
stbischof
force-pushed
the
osgi-master-fix
branch
from
4b1e8c9
to
173f672
Compare
This is not the problem which I referred to. But something is broken when I applied changes (some changes) from you PR for the The current state of my PR makes everything work. I would like to finish this endless journey and may be keep it as is in the working sate. But I would may be consider this as a separate extra PR : I really don't see any end of the changes. There are many many things which can be done to improve OSGi integration and cherry pick PR is not about every improvement: it should just enable initial OSGi support. |
|
i think updating bnd and osgi-deps you be a great improvement. but i am a still not sure what OSGi related unit tests in Eclipse does not run. what does i have to do to force this tests |
every test which has In the referenced commit there are only changes in |
|
and how to start? I cant not produce the error. |
I think there is a misunderstanding......... There are no any problems with these tests. The tests work even without these changes if they are executed via Maven. And this wasn't a problem for me. I was not able to run OSGi ITs with your latest changes for bnd version and I will check and let you know. |
|
hope this PR helps as i mentioned, osgi R7 deps and bnd are most importent |
denis-anisimov
approved these changes
Nov 11, 2020
| * @since | ||
| */ | ||
| @org.osgi.service.component.annotations.Component(immediate = true) |
There was a problem hiding this comment.
No need to use FQN. Just add an import.
|
I confirm that nothing is broken with this PR. Thanks! |
|
@stbischof , I've reverted Bnd maven plugin is quite seriously broken I'm packing Here are the snippets of MANIFEST with this version :
This bundle doesn't contain service components except one Many manifest headers are wrong. Here is the manifest made by The remaining part contains just bundle name and So |
|
@juergen-albert I am sure that bnd is not broken. Maybe checkerframework generates some source that bnd can find. @denis-anisimov These better Manifest helps the resolver a lot to resove a working framework and ServiceLoader handling! |
|
Also, I'm not sure whether this is related or not but doesn't work in our ITs config: OSGi tries to instantiate the component and it wants to use a default cosntructor. It's weird why it's broken because I've checked that it worked before accept the PR. I know that I didn't rebuild the ITs module from scratch to test but used the old one. Probably that's the reason. |
I don't understand what you mean. One more time:
|
Injecting bundleContext into a Constructor kame with R7 . bnd (with the newer versions) generates a xml file that describes this will have look on this problem this evening. |
I haven't used maven for quite some time, but as far as I remember does the war packaging cause maven to pack all the defined dependencies that are in certain scopes in the resulting war. This could mean, that bnd is analyzing all the dependent artifacts, when asked to build a manifest for it. @denis-anisimov can you provide a jar with this large manifest, so we can have a look? |
|
Besides this: Please use the latest bnd, because it produces much better metadata! |
|
flow-test-root-context-npm-6.0-SNAPSHOT-ui.jar |
|
As I have guessed. The dependencies are part of the jars classpath. The question would be, what the idea behind this jars is. Should they even be bundles or even jars? What is the idea behind packaging everything including the kitchen sink in the jars? |
|
Please ignore the older 2.5 builds
|
|
@juergen-albert thank you for the hint. if i exclude
now: if you add a there is no Please look into the bnd docs. It is a bit late an i am not sure. Web Archive Bundles https://bnd.bndtools.org/md/805-instructions.html there is an Import-Package instructions !com.vaadin.flow.uitest.servlet*, but cant see the package |
could show me the log in the build where the it fails. Lets check the spec: Bnd has generated this file WRONG if this entry is WRONG, then bnd version is 3.3 (see manifest for version) I pushed a commit of an OSGi-ITest you can see all from the log. bipolis@e367ef1
|
|
@denis-anisimov I run test tests on every other time failed with at last I got this errors from the same testClass as above |
|
I added I run the test of the one error happened here (completely other test): |
Well, any way is good for me. bnd maven plugin version And the module has bnd file for bundle manifest. If you know another way of proper packaging one module as a WAR and as a WAB please let me know. |
|
@stbischof , let's don't discuss things here in the closed PR. So: for now bnd version I will not accept any changes into the #9321 until it's merged and until |
|
Sure. I will create a PR against master. |
|
@denis-anisimov Please refrain from using bnd 3.3.0 it is ancient and 5.2 will produce much better Manifests. I don't know your exact setup and how the WAR and WAP will be deployed in OSGi. In short: Should this be a Bundle? If No: Just remove this line: If Yes: Use 3.3 only for this project or we might be able to tell bnd to not scan the included libs. |
from bnd-doc as above described |
It should be a bundle, yes: that's the target . It should be possible to deploy it to the OSGi container. |
|
@denis-anisimov could you please tell me which jars you want to have in the lib folder of the war. |
Complicated question. First of all : why do you talk about WAR? So is this question really about WAR or it's about JAR for OSGi ? |
I would create a WAB. One single zip file with the file-extention=war and an osgi manifest. I will make a PR. Then you could comment which artefacts should be excluded. BTW. @juergen-albert |
denis-anisimov
pushed a commit
that referenced
this pull request
Nov 18, 2020
…and osgi deps (#9361) refactor: OSGi improvements * update bnd-version Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * update osgi dependency and version Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * fix mocking osgi-classes Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * OSGiResourceProvider uses @component to declare the service Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * VaadinBundleTracker uses @component to declare the service Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * Remove `empty` BundleActivator Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * use constants for osgi.http.whiteboard.servlet.pattern Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * fix unregister Service PolymerPublishedEventRpcHandler Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * registers PolymerPublishedEventRpcHandler as a declarative service Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
pleku
pushed a commit
that referenced
this pull request
Dec 7, 2020
…and osgi deps (#9361) refactor: OSGi improvements * update bnd-version Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * update osgi dependency and version Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * fix mocking osgi-classes Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * OSGiResourceProvider uses @component to declare the service Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * VaadinBundleTracker uses @component to declare the service Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * Remove `empty` BundleActivator Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * use constants for osgi.http.whiteboard.servlet.pattern Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * fix unregister Service PolymerPublishedEventRpcHandler Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * registers PolymerPublishedEventRpcHandler as a declarative service Signed-off-by: Stefan Bischof <stbischof@bipolis.org>
TatuLund
added a commit
that referenced
this pull request
Dec 16, 2020
* test: Fix duplicate registration (#9233) Lock the registry when registering dynamic route in serviceInit to not have a race where 2 inits note that path is not registered and then try to register the route. Fixes #9223 * refactor: Remove log usage in embedded components (#9254) 8d012f7 removed some log and converted others into debug but log in disconnectedCallback was left. * refactor: expose the items count API to components (#9257) Exposes DataCommunicator::getDataProviderSize to the components, in order to get the items count taking into account the countCallback, if it has been set previously. Related-to: vaadin/flow-components#282 * chore: unit test for devmode-not-ready page contents and type (#9266) * chore: do not depend on commons.lang3 (#9271) * chore: fix typo (#9272) Fix typo in DataCommunicator::getDataProviderSize() javadoc. * fix: Sync HierarchicalDataCommunicator's expand state with client side (#9275) HierarchicalDataCommunicator's expanded state were not being synchronised with client side and TreeGrid's expanded nodes were being collapsed after re-attaching. Warranty: Sync TreeGrid expanded items state with the client side when detaching and reattaching Fixes: #9175 * chore: Bump version to 6.0-SNAPSHOT (#9279) * refactor: make web browser immutable (#9298) * feat: Create Flow plugins for webpack (#9295) * feat: Create Flow plugins for webpack Moved stats file handling to a custom plugin. Added feature for copying custom Flow plugins for use with webpack. Fixes #9283 * fix: AppShellConfigurator is now considered for theme endpoint (#9332) AppShellConfigurator is now also considered when scanning for annotations and deciding theme. Fixes #9110 * fix: fix TreeGrid updating wrong expanded items state on setDataProvider (#9336) Fixes: #9328 Details: HierarchicalDataProvider's reset method was called before recreating the HierrarchyMapper in setDataProvider. This was creating wrong updates for the client side. * feat!: Theme annotation should be only on AppShellConfigurator (#9313) Having the `@Theme` annotation on Flow views or router layouts will not be allowed anymore, it should be on `AppShellConfigurator` instead. Fixes #9092 * test(TypeScript): ensure CSRF token is updated when session is invalidated (#9329) * test(TypeScript): ensure CSRF token is updated when session is invalidated Fixes #9164 * add log message * fix: increase threshold for performance test (#9381) * fix: hide loading indicator when endpoint call fails (#9380) * feat: tree-shakeable ES imports for TS form validators (#9374) - Use tree-shakeable ES imports for TS form validators based on the latest version of validators lib. - Add missing `return` in the `submit()` method * feat: Theme can be defined as string or class (#9349) Add a string definition for theme that matches the "application theme" in the theme folder inside /frontend/theme/, loading the css automatically from there. This is based on Lumo theme, always. Change old class based theme to use themeClass for theme selection. Fixes #9281 * fix!: Use data view filter and sorting only to that component (#9315) In-memory filtering and sorting are now stored directly in component, which gives an opportunity to change it through the data view API for a certain component separately from other components bound to the same data provider. Fixes #8655 * fix: support Range requests with either start or end byte index omitted (#9368) Supports headers of the type Range: -123 and Range: 123-. Fixes #9083. * refactor: revert 'Use data view filter and sorting only to that component' (#9390) Revert the changes for #8655 to be able to bump the version of components and avoid compile errors. * chore: remove test module test-subcontext (#9394) This module is subsumed by test-router-custom-context. * chore: update readme with discord link (#9382) * test: remove Theme annotation from demo helpers module (#9395) * feat: Do not allow themeClass and themeName in same annotation (#9389) Theme Class and Theme Name is not supported in the same Theme annotation as theme name builds on the Lumo theme. test-themes is now for testing the Application theme only. Old theme test was moved into test-misc. Fixes #9370 * fix!: Use data view filter and sorting only to that component (#9315) In-memory filtering and sorting are now stored directly in component, which gives an opportunity to change it through the data view API for a certain component separately from other components bound to the same data provider. Fixes: #8655 * feat: Only use one theme and fail for duplicates (#9406) Now we only handle the theme with the name inside the Theme annotation. Fixes #9383 * Read stats.json content as a bundle resource in OSGi Read token file as a bundle resource in OSGi Fixes #9146 Fix NPE Revert logic back to the previous state # Conflicts: # flow-server/src/main/java/com/vaadin/flow/server/DeploymentConfigurationFactory.java # flow-server/src/main/java/com/vaadin/flow/server/frontend/FrontendUtils.java # flow-server/src/main/java/com/vaadin/flow/server/osgi/OSGiAccess.java * Refactor Instantiator and resources access Fixes #9185 Exclude non-serializable classes Drop dependency to flow-push from flow-server # Conflicts: # flow-server/src/main/java/com/vaadin/flow/server/BootstrapHandler.java # flow-server/src/main/java/com/vaadin/flow/server/DeploymentConfigurationFactory.java # flow-server/src/main/resources/META-INF/services/javax.servlet.ServletContainerInitializer # flow-server/src/test/java/com/vaadin/flow/server/connect/generator/endpoints/model/OSGiInstantiatorFactory.java # flow-server/src/test/java/com/vaadin/flow/server/connect/generator/endpoints/model/OSGiResourceProvider.java # flow-server/src/test/java/com/vaadin/flow/server/connect/typeconversion/StringConversionTest.java * Remove flow-osgi dep from flow-push, increase osgi cmpn version # Conflicts: # flow-push/pom.xml # flow-server/src/main/java/com/vaadin/flow/server/osgi/VaadinBundleTracker.java * Correct unit tests after refactoring: make them compiling Mock VaadinServlet in MockVaadinServletService Adapt unit tests for refactored code Adapt more unti tests and add one more new SPI method Fix serializable test, proceed with unit tests adaption Adapt unit tests for classes in com.vaadin.flow.server Adapt unit tests in the com.vaadin.flow.server.communication package * Adapt more unit tests * Make sure that ServletContextInitializers are executed after LookupInitializer Fix OSGi presence check to be able to run unit test Adapt servlet deployer unit tests Exclude OSGi related classes from test Exclude all OSGi impl classes from serializable test # Conflicts: # flow-polymer-template/src/test/java/com/vaadin/flow/component/polymertemplate/NpmTemplateParserTest.java # flow-server/src/main/java/com/vaadin/flow/server/DeploymentConfigurationFactory.java # flow-server/src/main/java/com/vaadin/flow/server/startup/ApplicationRouteRegistry.java # flow-server/src/main/resources/META-INF/services/javax.servlet.ServletContainerInitializer # flow-server/src/test/java/com/vaadin/flow/component/InvalidUrlTest.java # flow-server/src/test/java/com/vaadin/flow/component/UITest.java # flow-server/src/test/java/com/vaadin/flow/server/BootstrapHandlerDependenciesTest.java # flow-server/src/test/java/com/vaadin/flow/server/BootstrapHandlerTest.java # flow-server/src/test/java/com/vaadin/flow/server/DeploymentConfigurationFactoryTest.java # flow-server/src/test/java/com/vaadin/flow/server/I18NProviderTest.java # flow-server/src/test/java/com/vaadin/flow/server/MockServletServiceSessionSetup.java # flow-server/src/test/java/com/vaadin/flow/server/MockVaadinServletService.java # flow-server/src/test/java/com/vaadin/flow/server/VaadinServiceTest.java # flow-server/src/test/java/com/vaadin/flow/server/VaadinServletConfigurationTest.java # flow-server/src/test/java/com/vaadin/flow/server/VaadinServletServiceTest.java # flow-server/src/test/java/com/vaadin/flow/server/VaadinSessionTest.java # flow-server/src/test/java/com/vaadin/flow/server/communication/PushHandlerTest.java # flow-server/src/test/java/com/vaadin/flow/server/communication/WebComponentBootstrapHandlerTest.java # flow-server/src/test/java/com/vaadin/flow/server/frontend/FrontendUtilsTest.java # flow-server/src/test/java/com/vaadin/flow/server/startup/DevModeInitializerTestBase.java # flow-server/src/test/java/com/vaadin/flow/server/startup/EnableOSGiRunner.java # flow-server/src/test/java/com/vaadin/flow/server/startup/ServletDeployerTest.java * Fix OSGi Lookup related issues Fix OSGi related unit test one more time # Conflicts: # flow-osgi/src/main/java/com/vaadin/flow/osgi/support/OSGiResourceProvider.java # flow-server/src/main/java/com/vaadin/flow/server/VaadinServlet.java # flow-server/src/main/java/com/vaadin/flow/server/osgi/OSGiAccess.java # flow-server/src/main/java/com/vaadin/flow/server/osgi/VaadinBundleTracker.java # flow-server/src/main/java/com/vaadin/flow/server/startup/LookupInitializer.java # flow-server/src/test/java/com/vaadin/flow/server/startup/EnableOSGiRunner.java # flow-server/src/test/java/com/vaadin/flow/server/startup/OSGiInitApplicationRouteRegistryTest.java # flow-server/src/test/java/com/vaadin/flow/server/webcomponent/OSGiWebComponentConfigurationRegistryTest.java # flow-tests/test-root-context/src/main/java/com/vaadin/flow/osgi/Activator.java * Correct the resource access for VaadinService * Extend SPI, provide javadocs some unit tests fixes Minor code corrections, javadocs Correct unit test # Conflicts: # flow-polymer-template/src/test/java/com/vaadin/flow/component/polymertemplate/NpmTemplateParserTest.java # flow-server/src/test/java/com/vaadin/flow/server/communication/WebComponentBootstrapHandlerTest.java * test: add unit tests # Conflicts: # flow-tests/test-root-context/src/main/java/com/vaadin/flow/osgi/Activator.java * test: make it possible to run felix-jetty in npm mode # Conflicts: # flow-tests/servlet-containers/felix-jetty/pom.xml # flow-tests/test-root-context/pom-npm.xml * Make httpclient dependency optional for now. (#9262) * refactoring: move OSGi resource provider impl to flow-server (#9268) OSGi ResourceProvider impl should be available as a service at the moment when Vaadin WAB register a servlet. It's not possible without extra unclear config to make sure that the service is registered if it's in the flow-osgi : the bundle may be activated at any moment regardless of servlet registration. The issue doesn't appear if the service is registered at the flow-bundle start phase. * refactor: review fixes for OSGi (#9289) * refactoring: review fixes * chore: add a comment about Jar packaging in test-root-context module * fix: ensureServletContext should be always called * fix: fix review comments # Conflicts: # flow-tests/test-root-context/pom-npm.xml * refactor: get rid of cmpn osgi dependency (#9307) Not needed for flow-server. * refactoring: App classpath resources should be access via ResourceProvider (#9278) Fixes #9269 # Conflicts: # flow-polymer-template/src/main/java/com/vaadin/flow/component/polymertemplate/NpmTemplateParser.java # flow-server/src/main/java/com/vaadin/flow/server/BootstrapUtils.java * test: update unit tests * refactor: fix various OSGi related issues * add back lost classes during cherry-picks * fix unit tests * rewrite polymer template RPC * fix: fix javadocs after merge conflicts * fix: fix mocks in unit tests * test: Correct activator * refactor: correct lookup initializer filtering code * fix: fix javadocs (SQ) * refactor: Remove OSGi related ITs and osgi module from the repo * fix: fix some review comments * fix: test unstable test * refactor: get rid of OSGiClientStaticResource (#9277) * fix: use content parameter in the activate method * fix: Make OSGi incompatible vaadin-connect dependencies optional * fix: make Spring deps optional * fix: make a workaround for broken Route registry API * fix: avoid not-breaking exception ojn loading class from another bundle * fix: workaround for possible bug in route registry (like #9360). * [OSGi] - Cleanup BudleActivator and Service registration, Update bnd and osgi deps (#9361) refactor: OSGi improvements * update bnd-version Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * update osgi dependency and version Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * fix mocking osgi-classes Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * OSGiResourceProvider uses @component to declare the service Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * VaadinBundleTracker uses @component to declare the service Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * Remove `empty` BundleActivator Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * use constants for osgi.http.whiteboard.servlet.pattern Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * fix unregister Service PolymerPublishedEventRpcHandler Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * registers PolymerPublishedEventRpcHandler as a declarative service Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * fix: add explanation why OSGi Component annotation is safe to use * fix: code review fixes * fix: return back accidentially removed method and call init for service * fix: remove non-existent class pattern from test * fix: fix import order * fix: extract code to a separate method * fix: correct unit test * fix: fix unit test * refactor: simplify list merging * fix: return back lost code after review * fix: imports order * fix: revert bnd version * fix: imports order, review comments * fix: restore lost test method * fix: import orders * fix: revert not working deployment of test-root-context ui classifier * fix: check if Url contains directory change in Dev Mode (#9392) Checks whether the Url contains a directory change and a double encoding in Dev Mode. Returns 403 Forbidden immediately and skip the request handling, if does. * fix: preserve filter to not lose it between page requests (#9421) Data communicator's filter removal, which has been introduced for components with internal filtering (like a ComboBox), may lead to filter loss during the items scrolling. This fix reverts the filter removal and the components should implement this feature on their side, if necessary. Related-to: vaadin/flow-components#388 * chore: Update issue template with discord link (#9426) * chore: update chrome expectation to 87 (#9445) * fix: revert changes which broke route registration (#9432) Need to active the tracker from an servlet context initializer because @activate doesn't work on CTOR with parameter * chore: fix outdated AppShell javadoc (#9453) * test: add test for setting global font (#9436) Fixes #9409 * fix race-condition in IT-Tests (#9416) Signed-off-by: Stefan Bischof <stbischof@bipolis.org> * fix: mark tests that should not be executed in OSGi (#9456) * fix: mark tests that should not be executed in OSGi * fix: don't use push in route not found error page in OSGi * fix: avoid route with wildcard parameter which doesn't work in OSGi * fix: exclude wildcard parameter IT and devmode IT * fix: exclude "context" resource IT from OSGi tests * fix: make annotation packages optional in OSGi (#9465) Also fix test to first open page before checking client. fixes #9463 * fix: made VaadinRequest available in endpoint (#9442) * fix: made vaadinrequest available in endpoint * clear VaadinRequest instance after endpoint call * chore: remove mentions of “Connect” (#9151) * Rename “Connect” to “Fusion” * Remove “Fusion” naming * feat: Serve theme static files from VAADIN/static (#9451) Static files in META-INF/VAADIN/static will now be served on request to VAADIN/static. Added new webpack loader that changes app theme css urls targeting ./ and ../ to be VAADIN/static/ instead. Where ../ can not go outside of the application theme folder. Fixes #9405 * refactor: Remove OSGi code from flow-server (#9472) * refactor: Remove OSGi code from flow-server Fixes #9219 * chore: update Flow versions description (#9469) * feat: Theme component with app theme. (#9418) Added the feature that you can theme components with the app theme by creating a css file in 'frontend/theme/myTheme/components' with the component tag name e.g. 'my-field' should have 'my-field.css' Fixes #9348 * fix: check whether class implements an interface first directly (#9486) Part of #9480 * fix: remove instance field from singleton IndexHtmlRequestHandler (#9475) * fix: remove instance field from singleton IndexHtmlRequestHandler * apply code review suggestions * Stop logging error when updating dev dependencies (#9476) As there is a conflict with the dependencies and prevent adding the flow-dev-dependencies package to the platform (#9345), this will hide the unavoidable error that was logged for Vaadin apps. Fixes #9251 * fix: optimize handling of requests containing Range header (#9484) More efficient parsing of the header value. Also, range count is capped at 16 (additional will be ignored) and overlapping ranges at 2 (request will be denied if above). * fix: Correct regexp to only match when digit first (#9496) Use Matcher::find instead of Matcher::matches as matches never matched. Fixes #9494 * test: add test that external urls are not touched (#9482) Added test that we don't touch external urls (relative or abosolute). Moved flow to be under path so we can have jetty serve "external" resources. Fixes #9430 * fix: Add polyfill for constructable stylesheets (#9489) Add the constructable stylesheets polyfill so app theme also works with non chrome based browsers. Fixes #9488 * fix: Initialize VaadinServlet after Lookup is available (#9500) fix: don't initialize Vaadin servlet until Lookup is not available * feat: Enable adding assets from node_modules (#9495) * feat: Enable adding assets from node_modules It is now possible to import resources from installed node_modules by adding the asset to theme/my-theme/theme.json Fixes #9468 * Add comment to doc on copyStaticAssets * Fix url expectation after merge * format lines * test: add unit test for clear all in the servlet init method (#9507) * Fix: fix file system traversal of theme-loader to stop at root (#9505) The theme-loader recursion for themeFolder should stop at the root level. Also if no theme folder found we should not spend time on replacement. * fix: enable PlainScriptViaJavaScriptIT in OSGi (#9520) fixes #9461 * fix: enable PushRouteWildcardParameterIT in OSGi (#9518) fixes #9459 * fix: enable BaseHref IT back (#9515) Fixes #9458 * chore: Add information on logging in webpack (#9527) Added information on log levels with webpack loaders and plugins. * test: fix test class and register view servlet with a context in OSGi (#9528) Part of vaadin/osgi#5 * fix: removed `hasClientIssue("8236")` guard as ITs now pass (#9536) * Fix: Update Lit bundle parser regex. (#9546) Now the pattern will not fail with a StackOverflowException as we will search from the start character accepting any characters until we reach the caught start character with ; * fix: Enable lit css importing (#9550) Fixes #9532 * fix: use provided executor for frontend tools (#9553) fixes vaadin/spring#691 * feat: Resource handling to not need plugin copying (#9558) Fixed the url handling so that theme resources get prepended with theme/[themeName] while having the correct absolute path. With this we can handle these url resources with the css-loader which in turn leads to file-loader gettign the files for copying. External url are still not touched in any way. part of #9410 and #9533 * fix: file-loader name for windows execution (#9575) Windows file path separator \ should not be used as it will result in %0B when it should be / * test: Fixed flaky tests caused by variable ui in ValidatorTestBase.java (#9524) Added a ui variable in the ValidatorTestBase class to attach strong reference, in order to avoid garbage collecting it during the test run. * refactor: get Executor service from Lookup instead init params (#9572) fixes #9570 * fix: Add missing refreshAll method to data view Adds the missed refresh all method to data view API. Fixes: #9574 * chore: Update contributing guide with setup info (#9576) The contribution guide was missing the project setup information. There were outdated instructions in the readme, which was on the other hand not up to date and only had instructions for Eclipse. Now everything is in contribution guide and readme is short and simple, pointing to contribution guide for those who want to work with the project. * fix!: Make VaadinService.dependencyFilters unmodifiable While the change is backwards compatible from API perspective, it could be considered a behavior change although there is quite low risk of exposure in apps. Thus targeting 2.5 for the LTS and the recently released 5.0. * fix: encode attribute value during transfer from embedded web app (#9583) encode attribute value during transfer from embedded web app * chore: move fusion endpoint code to fusion-endpoint module (#9499) Fixes: #9354 move fusion code to a separate fusion-endpoint module, so that the fusion dependencies which are not OSGi compatible can be removed from the flow-server module. - move the code in the connect package to fusion-server - removed the non OSGi compatible packages from the bnd file in flow-server - change `TaskGenerateOpenApi` and `TaskGenerateConnect` to interfaces in flow-server, have the implementations in fusion-endpoint since they are using code inside the connect package - Move endpoint related tests: - from NodeTasksTest to NodeTasksEndpointTest, - from DevModeInitializerTest to DevModeInitializerEndpointTest - Add a `LookupImpl` class in the `flow-maven-plugin` module for finding endpoint services. - Introduce a `isInstantiableService`method in `ReflectTools` * feat: Embedded component appTheme support (#9588) Add support for application theme with embedded components. Fixes #8564 * feat: Enable importing CSS from node_modules (#9543) Enable using CSS files from installed node_modules by adding 'importCss' to theme/my-theme/theme.json. Fixes #9410 * refactor: simplify ResourceProvider (#9609) fixes #9605 * chore: add internal classes to access classloader and init context (#9618) * chore: add internal classes to access classloader and init context related to #9601 : needed to restore OSGi resource provider * fix: loading indicator visible and isActive true while endpoint fetch (#9593) * fix: loading indicator visible and isActive true while endpoint fetch * Clarified code and added test * fix: theme files can now be referenced as theme/theme-name (#9590) Theme files are now copied under theme/[theme-name] and can be referenced by theme/them-name/path/file.ff even though they are located at VAADIN/static Fixes: #9405 and #9535 * Fix: Generated theme.js is now named theme.generated.js (#9616) my-theme.js is now generated as my-theme.generated.js Fixes #9595 * Feat: Check that npm resources are available (#9617) Check that we have named npm resources available or throw an exception informing the user to install it using a NpmPackage annotation or manually with (p)npm i Fixes #9615 * refactor: rename the app-theme root folder from theme to themes (#9626) Fixes #9611 * refactor: refine renaming and incorrect paths in ThemeIT (#9634) * rename app-theme root folder to themes * chore: fix flaky tests that depends on mock count (#9631) * chore: create deepClean profile (#9311) Using the deepClean profile one can clean up all the generated files and node_modules folders from all test modules. * test: add document.css level styles tests (#9646) Adds a tests for checking that the document.css file is injected to the document scope and not injected to embedded element shadow root. Fixes #9552 * refactor: extract common config functionality and introduce add config (#9635) refactor: extract common config functionality and introduce add config part of #9417 Co-authored-by: caalador <mikael.grankvist@gmail.com> Co-authored-by: Guille <alvarezguille@users.noreply.github.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com> Co-authored-by: Johannes Eriksson <joheriks@vaadin.com> Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com> Co-authored-by: Denis <denis@vaadin.com> Co-authored-by: Artem Godin <fluorumlabs@users.noreply.github.com> Co-authored-by: Anton Platonov <anton@vaadin.com> Co-authored-by: Haijian Wang <30408303+haijian-vaadin@users.noreply.github.com> Co-authored-by: Pekka Hyvönen <pekka@vaadin.com> Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com> Co-authored-by: Stefan Bischof <33224746+stbischof@users.noreply.github.com> Co-authored-by: Jouni Koivuviita <jouni@vaadin.com> Co-authored-by: Jialin Shao <jialin_shao@outlook.com> Co-authored-by: Tan Bui <tan@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.