feat: allow endpoints to work on non-public classes #9592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
joheriks
suggested changes
Dec 10, 2020
flow-server/src/main/java/com/vaadin/flow/server/connect/VaadinConnectController.java
Outdated
Show resolved
Hide resolved
joheriks
previously approved these changes
Dec 10, 2020
haijian-vaadin
previously approved these changes
Dec 11, 2020
haijian-vaadin
dismissed stale reviews from joheriks and themself
via
2650b78
|
SonarQube analysis reported 1 issue Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
haijian-vaadin
changed the title
haijian-vaadin
changed the title
haijian-vaadin
approved these changes
Dec 16, 2020
|
This ticket/PR has been released with platform 19.0.0. For prerelease versions, it will be included in its final version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sets accessible all public methods of endpoint which allows to call them even if class is not public.
Checked with Oracle documentation that fix supports java 12 (there was a doubt that it's not)
https://docs.oracle.com/en/java/javase/12/docs/api/java.base/java/lang/reflect/AccessibleObject.html
Fixes #8168