Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: @ServiceRanking is not handled by the osgi bundle generation tool #9716

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

denis-anisimov
Copy link
Contributor

Use service.ranking property directly and avoid @ServiceRanking
annotation which for some reason is not handled by the bnd tools and no
rank is generated for the OSGI service descriptor.

Use service.ranking property directly and avoid @ServiceRanking
annotation which for some reason is not handled by the bnd tools and no
rank is generated for the OSGI service descriptor.
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 1 issue

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL DefaultApplicationConfigurationFactory.java#L175: Define a constant instead of duplicating this literal "jar!/" 3 times. rule

@denis-anisimov denis-anisimov merged commit 1744c1b into master Dec 23, 2020
@denis-anisimov denis-anisimov deleted the avoid-notworking-osgi-annotation branch December 23, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants