fix: peer dependency errors in npm 7 install #9856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: replace awesome-typescript-loader with ts-loader `awesome-typescript-loader` has not been updated in the last 2 years and does not guarantee compatibility with TypeScript 4+. `ts-loader` on the other hand is well maintained and tested with TypeScript 4+, and is the most popular Webpack loader for TypeScript files. Related to #9714. * use the allowTsInNodeModules option for ts-loader * Revert "use the allowTsInNodeModules option for ts-loader" This reverts commit 6a61d36. * use .js instead of .ts in @jsmodule for MyLitField Co-authored-by: haijian <haijian@vaadin.com>
This prevents missing files error from TypeScript / webpack in the IT tests, which happen when using deprecated Vaadin 14 bootstrapping and not using TypeScript.
haijian-vaadin
approved these changes
Jan 22, 2021
|
Doesn't this now mean that you can not use typescript with V14 Bootstrapping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9714