Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove old devDependencies #9931

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Conversation

caalador
Copy link
Contributor

@caalador caalador commented Feb 1, 2021

Clean away also old devDependencies
on Package update.

Fixes #9720

Clean away also old devDependencies
on Package update.

Fixes #9720
@caalador caalador added this to Iteration Reviews in OLD Vaadin Flow ongoing work (Vaadin 10+) via automation Feb 1, 2021
@pleku
Copy link
Contributor

pleku commented Feb 3, 2021

Should this be targeting 2.4, 2.5 and 5.0 too ?

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Feb 3, 2021
@caalador caalador added +0.0.1 and removed +1.0.0 labels Feb 3, 2021
@tanbt tanbt merged commit 83afd70 into master Feb 3, 2021
OLD Vaadin Flow ongoing work (Vaadin 10+) automation moved this from Iteration Reviews to Done - pending release Feb 3, 2021
@tanbt tanbt deleted the issues/9720_clean_dev_dependencies branch February 3, 2021 12:41
tanbt pushed a commit that referenced this pull request Feb 5, 2021
* fix: Remove old devDependencies

Clean away also old devDependencies
on Package update.

Fixes #9720

* Combine dependency cleanup parts.
tanbt pushed a commit that referenced this pull request Feb 5, 2021
* fix: Remove old devDependencies

Clean away also old devDependencies
on Package update.

Fixes #9720

* Combine dependency cleanup parts.
tanbt pushed a commit that referenced this pull request Feb 5, 2021
* fix: Remove old devDependencies

Clean away also old devDependencies
on Package update.

Fixes #9720

* Combine dependency cleanup parts.
tanbt pushed a commit that referenced this pull request Feb 9, 2021
* fix: Remove old devDependencies

Clean away also old devDependencies
on Package update.

Fixes #9720

* Combine dependency cleanup parts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
OLD Vaadin Flow ongoing work (Vaadin ...
  
Done - pending release
Development

Successfully merging this pull request may close these issues.

unused npm dev dependencies, once added by Vaadin, are never removed
4 participants