test: Linux local build fixes #9942
Conversation
BinderTest#withConverter_writeBackValue was failing depending on the locale. Now it's locale aware and does not fail when run on any (e.g. spanish) locale
…uriWithDirectoryChange_statusForbidden The UrlValidationIT#devModeUriValidation_uriWithDirectoryChange_statusForbidden test was failing due to a race condition. Now it checks the response body to verify that the frontend is compiled, and it performs as expected
|
|
flow-data/src/test/java/com/vaadin/flow/data/binder/BinderTest.java
Outdated
Show resolved
Hide resolved
flow-tests/test-dev-mode/src/test/java/com/vaadin/flow/uitest/ui/UrlValidationIT.java
Show resolved
Hide resolved
flow-tests/test-dev-mode/src/test/java/com/vaadin/flow/uitest/ui/UrlValidationIT.java
Show resolved
Hide resolved
flow-tests/test-dev-mode/src/test/java/com/vaadin/flow/uitest/ui/UrlValidationIT.java
Outdated
Show resolved
Hide resolved
|
Thanks for fixing the timing issue, @miguelatvaadin ! I was not taking it into consideration when made this test. |
…r timeout handling
| } | ||
|
|
||
| private String getResponseBody(HttpURLConnection connection) throws IOException { | ||
| String body = String.join("\n", IOUtils.readLines(connection.getInputStream(), StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
I think we had this policy of not using Apahce Commons and etc. because of versioning conflicts and the challenges it creates for the users and should be avoided. However, this comment is just a reminder, since this is a test code. No action needed IMO.
There was a problem hiding this comment.
Yes, I saw it in the wiki. Anyway, IOUtils was already used in several points in the project, even in flow-server, so I understand it's not a problem.
| import com.vaadin.flow.testutil.ChromeBrowserTest; | ||
|
|
||
| import org.apache.commons.io.IOUtils; | ||
| import org.junit.Assert; | ||
| import org.junit.Test; |
There was a problem hiding this comment.
I believe com.vaadin.* imports should appear after all other imports and before elemental.* and import static statements. Although the code was like that even before these changes, but it's a chance to fix them here ;)
There was a problem hiding this comment.
ok. I will change this. Thanks, Soroosh ;)
|
Needs a merge with latest |
Ok. I go for it. Thanks! |
These commits fix some issues which arise while locally building the project on a linux desktop