Skip to content

Commit

Permalink
Add detection of HCL Digital Experience rebranding (#12242) (#12369)
Browse files Browse the repository at this point in the history
On HCL Digital Experience 8.5.5 CF19, the `getPortalInfo()` method
returns "hcl digital experience/8.5", breaking detection of the servlet
engine.

This ultimately leads to methods such as `getHeader()` to return NULL,
as the upstream HTTP request is not retrieved.

Authored-by: Marcello Barnaba <vjt@openssl.it>
  • Loading branch information
Ansku committed Aug 11, 2021
1 parent 94dfd1c commit 09f1f3d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server/src/main/java/com/vaadin/server/VaadinPortlet.java
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ protected VaadinPortletRequest createVaadinRequest(PortletRequest request) {
return new VaadinLiferayRequest(request, service);
}

if (portalInfo.contains("websphere portal")) {
if (portalInfo.contains("websphere portal") || portalInfo.contains("hcl digital experience")) {
return new VaadinWebSpherePortalRequest(request, service);
}
if (portalInfo.contains("weblogic portal")) {
Expand Down

0 comments on commit 09f1f3d

Please sign in to comment.