Make test for EditorSaveEvent.bean field

* Fixes #8810, #8658
vaadin · Mar 14, 2017 · 156da8b · 156da8b
1 parent e786963
commit 156da8b
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/server/src/main/java/com/vaadin/ui/components/grid/EditorImpl.java b/server/src/main/java/com/vaadin/ui/components/grid/EditorImpl.java
@@ -265,9 +265,10 @@ public void cancel() {
     }
 
     private void doCancel(boolean afterBeingSaved) {
+        T editedBean = edited;
         doClose();
         if (!afterBeingSaved) {
-            eventRouter.fireEvent(new EditorCancelEvent<>(this, edited));
+            eventRouter.fireEvent(new EditorCancelEvent<>(this, editedBean));
         }
     }
 

diff --git a/server/src/test/java/com/vaadin/tests/server/component/grid/EditorImplTest.java b/server/src/test/java/com/vaadin/tests/server/component/grid/EditorImplTest.java
@@ -18,6 +18,7 @@
 import java.util.Optional;
 import java.util.stream.Stream;
 
+import com.vaadin.ui.Grid;
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
@@ -43,6 +44,11 @@ public class EditorImplTest {
     public static class TestEditorImpl extends EditorImpl<Object> implements
             EditorSaveListener<Object>, EditorCancelListener<Object> {
 
+        @Override
+        public void doEdit(Object bean) {
+            super.doEdit(bean);
+        }
+
         public TestEditorImpl() {
             super(new PropertySet<Object>() {
                 @Override
@@ -56,6 +62,12 @@ public TestEditorImpl() {
                     return null;
                 }
             });
+
+        }
+
+        @Override
+        public Grid<Object> getParent() {
+            return new Grid<>();
         }
 
         EditorCancelEvent<Object> cancelEvent;
@@ -64,11 +76,6 @@ public TestEditorImpl() {
 
         EditorServerRpc rpc;
 
-        @Override
-        public boolean isOpen() {
-            return true;
-        }
-
         @Override
         public boolean isBuffered() {
             return true;
@@ -99,6 +106,8 @@ protected <T extends ServerRpc> void registerRpc(T implementation) {
         }
     }
 
+    private Object beanToEdit = new Object();
+
     private TestEditorImpl editor;
     private Binder<Object> binder;
 
@@ -109,6 +118,8 @@ public void setUp() {
         editor.addCancelListener(editor);
         binder = Mockito.mock(Binder.class);
         editor.setBinder(binder);
+        editor.setEnabled(true);
+        editor.doEdit(beanToEdit);
     }
 
     @Test
@@ -121,6 +132,7 @@ public void save_eventIsFired() {
         Assert.assertNull(editor.cancelEvent);
 
         Assert.assertEquals(editor, editor.saveEvent.getSource());
+        Assert.assertEquals(beanToEdit, editor.saveEvent.getBean());
     }
 
     @Test
@@ -131,6 +143,8 @@ public void cancel_eventIsFired() {
         Assert.assertNotNull(editor.cancelEvent);
 
         Assert.assertEquals(editor, editor.cancelEvent.getSource());
+
+        Assert.assertEquals(beanToEdit, editor.cancelEvent.getBean());
     }
 
     @Test
@@ -143,6 +157,8 @@ public void saveFromClient_eventIsFired() {
         Assert.assertNull(editor.cancelEvent);
 
         Assert.assertEquals(editor, editor.saveEvent.getSource());
+
+        Assert.assertEquals(beanToEdit, editor.saveEvent.getBean());
     }
 
     @Test
@@ -153,6 +169,8 @@ public void cancelFromClient_eventIsFired() {
         Assert.assertNotNull(editor.cancelEvent);
 
         Assert.assertEquals(editor, editor.cancelEvent.getSource());
+
+        Assert.assertEquals(beanToEdit, editor.cancelEvent.getBean());
     }
 
     @Test