Grid has wrong width if no header

[fante76]

Vaadin Framework 8.2.0

A grid without header (by grid.removeHeaderRow(0)) doesn't apply width settings, both on single columns then in whole grid.
The following code works on Vaadin 8.7.1

capGrid.setItems(capabilities);
capGrid.removeHeaderRow(0);
capGrid.setColumns("name");
capGrid.getColumn("name").setExpandRatio(1).setWidth(200);
capGrid.setSizeFull():

[rappenze]

This bug was introduced with pull request #10384. The code to add select all checkbox does not check if the header exists.

So this bug is limited to grids where no default header row exists and the grid is in multi select mode.

Client side exception is:

[stale]

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

• Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
• Provide more details how to reproduce the issue.
• Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
• Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
• Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
• If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

[buuzta]

Bug still exists in Vaadin 8.5.1.
Happens either with removeHeaderRow(0) or setHeaderVisible(false).

[anasmi]

Hi,

please, correct me, if I am wrong, but I don't think this is a bug per se.
In your code you are setting explicitly the width and the expand rate on the same column simultaneously. In this case width is taking precedence.(The result you see) If you want to specify the minimum width column should have, then you should probably use setMinimumWidth.

                   Grid<String> grid = new Grid<>();
                    grid.addColumn(ValueProvider.identity());
                    grid.addColumn(String::valueOf).setExpandRatio(1).setWidth(250);
                    grid.setItems("a", "b");
                    grid.setSizeFull();
                    grid.setSelectionMode(Grid.SelectionMode.MULTI);
                   // grid.setHeaderVisible(false);

The code above produce to me the same visual result regardless of me having header column or not. (I hope its reproduce your use case also)

Using setWidth:

Using setMinimunWidth instead:

Have I miss something? Could you share the code you have, if it's not the same as above?

[fante76]

My code is written above. The problem happens using grid.removeHeaderRow(0), you are not using it on your example. May be your workaround fits, I will try as soon as possible, but you can't said its not a bug.

[anasmi]

Hi,

indeed you are correct. When removing the row like you did I was able to reproduce the back.
In a meanwhile, you can use grid.setHeaderVisible(false); as a workaround, but problem does indeed exist.

Thanks for clarifications!