Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be LocalDateRenderer and LocalDateTimeRenderer #8377

Closed
pleku opened this issue Jan 30, 2017 · 3 comments
Closed

There should be LocalDateRenderer and LocalDateTimeRenderer #8377

pleku opened this issue Jan 30, 2017 · 3 comments
Assignees
Milestone

Comments

@pleku
Copy link
Contributor

pleku commented Jan 30, 2017

@pleku commented on Mon Oct 03 2016

DateRenderer should not be Date based, should use e.g. Instant or something else so that user doesn't have to convert to Date.
Another option would be to have several Date related renderers for each type ? E.g. InstantRenderer, LocalDateRenderer ...


@pleku commented on Tue Oct 11 2016

SHOULD HAVE, but not necessary for FW8.

@Legioth
Copy link
Member

Legioth commented Jan 31, 2017

I don't think the existing DateRenderer should be changed. We should instead introduce a new class with similar functionality but a different input type.

@nikkijuk
Copy link

nikkijuk commented Feb 8, 2017

I will today try to implement my own LocalDateRenderer because I need one, and I believe everyone using Java 8 date types will at the end do the same.. I can't wait Vaadin 8.1 and I believe many others won't wait either.

Turns out there's something I need to know better to do LocalDateRenderer: tried it, but didn't want to spend too much time on debugging and turned back to preformatting dates to strings in value provider of field.

@pleku pleku changed the title DateRenderer should not be Date based There should be LocalDateRenderer and LocalDateTimeRenderer Mar 1, 2017
@pleku pleku modified the milestone: 8.1.0 Mar 15, 2017
@ahie ahie self-assigned this Mar 24, 2017
@markathomas
Copy link

+1 - this is problematic now that DateField returns LocalDate but DateRenderer requires Date

@pleku pleku added this to the 8.1.0.alpha3 milestone Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants