Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid expanded columns resize to minimum (header) width if grid is reAttached #9203

Closed
walindner opened this issue Apr 30, 2017 · 2 comments
Closed

Comments

@walindner
Copy link

walindner commented Apr 30, 2017

version 8.05

if the button is pressed in the following example, the width of column2 changes in a wrong way.
On browser window resize the column width is corrected.

The grid can be reattached in different ways:

  • wrapping layout is exchanged
  • grid is placed on a tabsheet, user changes tabs
  • ...

import com.vaadin.ui.*;

import java.util.stream.IntStream;

public class GridColumnSizing extends CustomComponent {

private final Grid<Integer> grid;
private final Button button = new Button("rebuild layout");

public GridColumnSizing() {
    this.grid = new Grid<Integer>();
    this.grid.setSizeFull();
    this.grid.addColumn(i -> i)
            .setCaption("column1")
            .setWidth(100);

    this.grid.addColumn(i -> i / 2)
            .setCaption("column2")
            .setExpandRatio(1);
    fillItems();
    this.button.addClickListener(event -> rebuildLayout());
    rebuildLayout();
}

private void fillItems() {
    this.grid.setItems(IntStream.rangeClosed(1, 100).boxed());
}

private void rebuildLayout() {
    HorizontalLayout horizontalLayout = new HorizontalLayout();
    horizontalLayout.setSizeFull();
    horizontalLayout.addComponents(this.grid, this.button);
    setCompositionRoot(horizontalLayout);
}

}

@walindner walindner changed the title Grid expanded columns resize to minimum width if wrapping layout is exchanged Grid expanded columns resize to minimum width if grid is reAttached Jun 22, 2017
@walindner walindner changed the title Grid expanded columns resize to minimum width if grid is reAttached Grid expanded columns resize to minimum (header) width if grid is reAttached Jun 22, 2017
@stale
Copy link

stale bot commented Mar 19, 2018

Hello there!

It looks like this issue hasn't progressed lately. There are so many issues that we just can't deal them all within a reasonable timeframe.

There are a couple of things you could help to get things rolling on this issue (this is an automated message, so expect that some of these are already in use):

  • Check if the issue is still valid for the latest version. There are dozens of duplicates in our issue tracker, so it is possible that the issue is already tackled. If it appears to be fixed, close the issue, otherwise report to the issue that it is still valid.
  • Provide more details how to reproduce the issue.
  • Explain why it is important to get this issue fixed and politely draw others attention to it e.g. via the forum or social media.
  • Add a reduced test case about the issue, so it is easier for somebody to start working on a solution.
  • Try fixing the issue yourself and create a pull request that contains the test case and/or a fix for it. Handling the pull requests is the top priority for the core team.
  • If the issue is clearly a bug, use the Warranty in your Vaadin subscription to raise its priority.

Thanks again for your contributions! Even though we haven't been able to get this issue fixed, we hope you to report your findings and enhancement ideas in the future too!

@stale stale bot added the Stale Stale bot label label Mar 19, 2018
@TatuLund
Copy link
Contributor

TatuLund commented May 4, 2018

Is this duplicate of #10438 ? If yes, this is fixed and should be closed.

@stale stale bot removed the Stale Stale bot label label May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants