Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to access features of SelectionModels #10939

Merged
merged 1 commit into from Sep 4, 2018
Merged

Conversation

tsuoanttila
Copy link
Contributor

@tsuoanttila tsuoanttila commented May 22, 2018

This patch makes Grid.asMultiSelect and Grid.asSingleSelect return
a special object that has API to access the features of corresponding
selection models.


This change is Reviewable

This patch makes Grid.asMultiSelect and Grid.asSingleSelect return
a special object that has API to access the features of corresponding
selection models.
@elmot
Copy link
Contributor

elmot commented May 22, 2018

Review status: 0 of 4 files reviewed at latest revision, all discussions resolved.


server/src/test/java/com/vaadin/tests/components/grid/GridSelectionModeTest.java, line 90 at r1 (raw file):

                // Skip methods from Extension interface
                Extension.class.getMethod(method.getName(),
                        method.getParameterTypes());

Why java.lang.reflect.Method#getDeclaringClass is not used for this?
Not a blocker


Comments from Reviewable

Copy link
Contributor

@elmot elmot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tsuoanttila)

@elmot elmot merged commit 5a24c48 into master Sep 4, 2018
@elmot elmot deleted the feature/grid_as_select branch September 4, 2018 12:45
@elmot elmot added this to the 8.6.0 milestone Sep 5, 2018
@ZheSun88 ZheSun88 modified the milestones: 8.6.0, 8.6.0.alpha2 Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants