Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compensate for Grid editor moving out of sync horizontally. #11092

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Jul 27, 2018

Fixes #10998


This change is Reviewable

Copy link
Contributor

@tsuoanttila tsuoanttila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ansku)


client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2145 at r1 (raw file):

            // sometimes focus handling twists the editor row out of alignment
            // with the grid itself and the position needs to be compensated for
            if (!grid.getEditor().columnToWidget.isEmpty()) {

How is this if check decided?


client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2150 at r1 (raw file):

                int rowLeft = rowElement.getAbsoluteLeft();
                int editorLeft = cellWrapper.getAbsoluteLeft();
                if (editorLeft != rowLeft + frozenWidth) {

Could we always do this calculation and decide based on this if which value to use?

@Ansku
Copy link
Member Author

Ansku commented Aug 1, 2018


client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2145 at r1 (raw file):

Previously, tsuoanttila (Teemu Suo-Anttila) wrote…

How is this if check decided?

Outdated, removed.

@TatuLund TatuLund added the v7 label Aug 1, 2018
Copy link
Member Author

@Ansku Ansku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @tsuoanttila)


client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2150 at r1 (raw file):

Previously, tsuoanttila (Teemu Suo-Anttila) wrote…

Could we always do this calculation and decide based on this if which value to use?

Done.

Copy link
Member Author

@Ansku Ansku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @tsuoanttila)


client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2145 at r1 (raw file):

Previously, Ansku (Anna Koskinen) wrote…

Outdated, removed.

Done.

Copy link
Contributor

@elmot elmot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Dismissed @tsuoanttila from 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@elmot elmot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@elmot elmot merged commit 062caa5 into vaadin:7.7 Aug 13, 2018
OlliTietavainenVaadin added a commit to OlliTietavainenVaadin/framework that referenced this pull request Nov 14, 2018
@OlliTietavainenVaadin OlliTietavainenVaadin added this to the 7.7.16 milestone Nov 27, 2018
ZheSun88 pushed a commit that referenced this pull request Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants