-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compensate for Grid editor moving out of sync horizontally. #11092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Ansku)
client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2145 at r1 (raw file):
// sometimes focus handling twists the editor row out of alignment // with the grid itself and the position needs to be compensated for if (!grid.getEditor().columnToWidget.isEmpty()) {
How is this if check decided?
client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2150 at r1 (raw file):
int rowLeft = rowElement.getAbsoluteLeft(); int editorLeft = cellWrapper.getAbsoluteLeft(); if (editorLeft != rowLeft + frozenWidth) {
Could we always do this calculation and decide based on this if which value to use?
client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2145 at r1 (raw file): Previously, tsuoanttila (Teemu Suo-Anttila) wrote…
Outdated, removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @tsuoanttila)
client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2150 at r1 (raw file):
Previously, tsuoanttila (Teemu Suo-Anttila) wrote…
Could we always do this calculation and decide based on this if which value to use?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @tsuoanttila)
client/src/main/java/com/vaadin/client/widgets/Grid.java, line 2145 at r1 (raw file):
Previously, Ansku (Anna Koskinen) wrote…
Outdated, removed.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Dismissed @tsuoanttila from 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
Fixes #10998
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)