Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @PushStateNavigation with @PreserveOnRefresh #11417

Merged
merged 1 commit into from Jan 11, 2019
Merged

Fix @PushStateNavigation with @PreserveOnRefresh #11417

merged 1 commit into from Jan 11, 2019

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Jan 9, 2019

Navigation needs to be done also in doRefresh(..) in similar fashion as in doInit(..)

Fixes #11416


This change is Reviewable

Navigation needs to be done also in doRefresh(..) in similar fashion as in doInit(..)

Fixes #11416
Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@ZheSun88 ZheSun88 added this to the 8.7.0 milestone Jan 11, 2019
@ZheSun88 ZheSun88 merged commit 9d2dd8b into master Jan 11, 2019
@ZheSun88 ZheSun88 deleted the fix11416 branch January 11, 2019 11:22
ZheSun88 pushed a commit that referenced this pull request Jan 17, 2019
Navigation needs to be done also in doRefresh(..) in similar fashion as in doInit(..)

Fixes #11416
ZheSun88 pushed a commit that referenced this pull request Jan 22, 2019
Navigation needs to be done also in doRefresh(..) in similar fashion as in doInit(..)

Fixes #11416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants