New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression that broke PreserveOnRefresh functionality with Navigator #11615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @TatuLund)
a discussion (no related file):
Current build failed, because of the Chrome 75 update.
this patch is waiting for a test also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @ZheSun88)
a discussion (no related file):
Previously, ZheSun88 (Zhe Sun) wrote…
Current build failed, because of the Chrome 75 update.
this patch is waiting for a test also.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
Fixes #11614
Old patch #11416 called navigateTo allways when Navigator was present, which is wrong, since it needs to be called only when navigation state has changed.
This change is