Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add JavaDoc warning to avoid using ResponseWriter for directories #12337

Merged
merged 1 commit into from Jul 5, 2021

Conversation

Ansku
Copy link
Member

@Ansku Ansku commented Jul 5, 2021

(#12324)

Cherry-picked from: vaadin/flow#11112


This change is Reviewable

Copy link
Member

@OlliTietavainenVaadin OlliTietavainenVaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ansku)

@OlliTietavainenVaadin OlliTietavainenVaadin merged commit 0259a37 into 8.13 Jul 5, 2021
@Ansku Ansku deleted the pr12324release branch July 5, 2021 09:32
@ZheSun88 ZheSun88 added this to the 8.13.2 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants