Reworked and cleaned up client-side TabSheet and Accordion. #12357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Ansku
force-pushed
the
updateTabSheet20210804
branch
2 times, most recently
from
756d067
to
03f61b9
Compare
Ansku
force-pushed
the
updateTabSheet20210804
branch
from
03f61b9
to
bdc1832
Compare
Ansku
force-pushed
the
updateTabSheet20210804
branch
from
bdc1832
to
c19811a
Compare
Ansku
force-pushed
the
updateTabSheet20210804
branch
from
c19811a
to
b4b7412
Compare
OlliTietavainenVaadin
approved these changes
Aug 13, 2021
- Added and corrected JavaDocs. - Deprecated unused public methods. - Fixed first tab style logic in TabSheet. - Fixed navigation focus logic in TabSheet. - Fixed tab width bookkeeping for scrolling TabSheet tabs. - Renamed private methods and variables for clarity. - Removed unnecessary or duplicated private methods. - Reworked some logic to clarify it and to better match my understanding of what's supposed to happen within those methods. - Updated some deprecated method calls to use currently recommended solutions. - Added and updated regression tests.
Ansku
force-pushed
the
updateTabSheet20210804
branch
from
b4b7412
to
b3de38a
Compare
| @@ -1248,6 +1767,8 @@ private boolean isScrollerAtFirstVisibleTab() { | |||
| */ | |||
| @Deprecated | |||
| public class PlaceHolder extends VLabel { | |||
There was a problem hiding this comment.
ClassCanBeStatic: Inner class is non-static but does not reference enclosing class
(at-me in a reply with help or ignore)
| TableCellElement spacerCell = ((TableElement) tb.getElement().cast()) | ||
| .getRows().getItem(0).getCells().getItem(tb.getTabCount()); | ||
| // This element is hidden by Valo, test with legacy themes. | ||
| TableCellElement spacerCell = ((TableCellElement) tb.spacerTd.cast()); | ||
| if (scroller.getStyle().getDisplay() != "none") { |
There was a problem hiding this comment.
ReferenceEquality: Comparison using reference equality instead of value equality
(at-me in a reply with help or ignore)
OlliTietavainenVaadin
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of what's supposed to happen within those methods.
solutions.