Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken Grid documentation addColumn setHeaderCaption #8213

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Conversation

pleku
Copy link
Contributor

@pleku pleku commented Jan 11, 2017

This change is Reviewable

@hesara
Copy link
Contributor

hesara commented Jan 11, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


documentation/components/components-grid.asciidoc, line 264 at r1 (raw file):

be obtained from the grid with [methodname]#getColumns()#.

The setter methods in [classname]#Column# fluent, so you can easily chain

verb missing


Comments from Reviewable

@pleku
Copy link
Contributor Author

pleku commented Jan 11, 2017

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.


documentation/components/components-grid.asciidoc, line 264 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…

verb missing

Done.


Comments from Reviewable

@hesara
Copy link
Contributor

hesara commented Jan 11, 2017

:lgtm:


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@pleku pleku merged commit c2ad28c into master Jan 11, 2017
@pleku pleku deleted the fix_grid_docs branch January 11, 2017 18:27
@tsuoanttila tsuoanttila added this to the Legacy milestone Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants