Properly end HTML5 drag operations when no drop is performed #8242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
Needs rebase and there is a compilation error. |
No auto test because of SeleniumHQ/selenium#1365 Fixes vaadin#4060
Artur-
force-pushed
the
_end_html5_nodrop
branch
from
8bdd9a6
to
2f62667
Compare
|
been there, done that |
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No auto test because of SeleniumHQ/selenium#1365
Fixes #4060
This change is