Support Vaadin custom protocols in Vaadin-Refresh redirects #8597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR contains a commit that was already merged separately - if that does not cause squash/merge issues, looks ok to me Reviewed 13 of 13 files at r1, 5 of 5 files at r2. uitest/src/main/webapp/statictestfiles/login.html, line 5 at r2 (raw file):
(EOL - not a blocker) Comments from Reviewable |
A login page you want to redirect to is typically in the webapp root, which you can now refer to as "Vaadin-Refresh: context://login.html"
Artur-
force-pushed
the
protocols-vaadin-refresh
branch
from
bc46eaf
to
4487f9a
Compare
|
Review status: 4 of 5 files reviewed at latest revision, 1 unresolved discussion. uitest/src/main/webapp/statictestfiles/login.html, line 5 at r2 (raw file): Previously, hesara (Henri Sara) wrote…
Done. Comments from Reviewable |
|
Reviewed 1 of 1 files at r3. Comments from Reviewable |
elmot
pushed a commit
that referenced
this pull request
Mar 16, 2017
A login page you want to redirect to is typically in the webapp root, which you can now refer to as "Vaadin-Refresh: context://login.html"
tsuoanttila
pushed a commit
that referenced
this pull request
Mar 16, 2017
A login page you want to redirect to is typically in the webapp root, which you can now refer to as "Vaadin-Refresh: context://login.html"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is