Set column captions when reading grid from a design file

[Artur-]

Depends on #8769

---

This change is 

[hesara]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

---

server/src/main/java/com/vaadin/ui/Grid.java, line 3601 at r1 (raw file):

        if (this.beanType != null) {
            design.attr(DECLARATIVE_DATA_ITEM_TYPE,
                    this.beanType.getCanonicalName());

I think canonical name - while human readable and perhaps the correct one in the design file - isn't what Class.forName() expects, and differs for nested classes

---

Comments from Reviewable

[Artur-]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion.

---

server/src/main/java/com/vaadin/ui/Grid.java, line 3601 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…

I think canonical name - while human readable and perhaps the correct one in the design file - isn't what Class.forName() expects, and differs for nested classes

Maybe, but that code is not part of this patch. It was part of #8769

---

Comments from Reviewable

[pleku]

Reviewed 1 of 2 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable