-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check Trident version to detect compatibility mode #8884
Conversation
IE11 in compatibility mode is actually not too old. It's just not recognized as IE11 if you leave the Trident version out of the equation. Checking the Trident version is something Vaadin 7 (since 7.0.0.beta5) does: fc15f16 Trident 4 -> IE8 Trident 5 -> IE9 Trident 6 -> IE10 Trident 7 -> IE11 (windows 7, 10) Trident 8 -> IE11 (windows 10 initial release only)
Check the Trident version in a different place and use it to determine the actual IE version instead of trusting the possibly emulated MSIE version string.
Reviewed 1 of 1 files at r1. a discussion (no related file): If you don't have the time to do that, I can add the test myself, but the main question is: what is the user agent for IE11 in compatibility mode ? Need to try to look that up Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions. shared/src/main/java/com/vaadin/shared/VBrowserDetails.java, line 155 at r2 (raw file):
This is the kind of magic that I should be described in a comment, I know Microsoft works in mysterious ways, but still, where does this come from ? Comments from Reviewable |
Reviewed 1 of 1 files at r2. Comments from Reviewable |
- IE11 Windows 7 compatibility view (CV) IE7 - IE11 Windows 10 CV IE7 - IE11 launch day Windows 10 CV IE7
Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions. a discussion (no related file): Previously, pleku (Pekka Hyvönen) wrote…
Added three new tests. For reference: When in compatibility mode (they all start reporting IE7 by default) shared/src/main/java/com/vaadin/shared/VBrowserDetails.java, line 155 at r2 (raw file):
Comments from Reviewable |
Reviewed 2 of 2 files at r3. Comments from Reviewable |
@pleku Will this end up in 8.0.4 or should I have approached making this contribution differently if that was my goal? And if so, what would I need to do to get it merged into 8.0.4 too? |
@Darsstar don't worry I'm picking it to 8.0.4 |
IE11 in compatibility mode is actually not too old. It's just not recognized as IE11 if you leave the Trident version out of the equation. Checking the Trident version and using it to determine the actual IE version instead of trusting the possibly emulated MSIE version string.
IE11 in compatibility mode is actually not too old. It's just not recognized as IE11 if you leave the Trident version out of the equation. Checking the Trident version and using it to determine the actual IE version instead of trusting the possibly emulated MSIE version string.
IE11 in compatibility mode is actually not too old. It's just not recognized as IE11 if you leave the Trident version out of the equation.
Checking the Trident version is something Vaadin 7 (since 7.0.0.beta5) does: fc15f16
Trident 4 -> IE8
Trident 5 -> IE9
Trident 6 -> IE10
Trident 7 -> IE11 (windows 7, 10)
Trident 8 -> IE11 (windows 10 initial release only)
This change is