Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 bugfix/4035 #8898

Merged
merged 11 commits into from
Mar 22, 2017
Merged

V8 bugfix/4035 #8898

merged 11 commits into from
Mar 22, 2017

Conversation

OlliTietavainenVaadin
Copy link
Member

@OlliTietavainenVaadin OlliTietavainenVaadin commented Mar 21, 2017

Fixes #4035 Flash expansion


This change is Reviewable

@hesara
Copy link
Contributor

hesara commented Mar 21, 2017

Reviewed 3 of 4 files at r1.
Review status: 3 of 4 files reviewed at latest revision, 3 unresolved discussions.


client/src/main/java/com/vaadin/client/ui/VFlash.java, line 146 at r1 (raw file):

     * Triggers embed resizing if percentage sizes are in use.
     *
     * @since

(could already fill this as 7.7.8 as it looks almost certain the 7.7 fix will be released in it)


client/src/main/java/com/vaadin/client/ui/flash/FlashConnector.java, line 2 at r1 (raw file):

/*
 * Copyright 2000-2014 Vaadin Ltd.

should still be 2016, I think (we'll later make a more global update for 2017 in the context of #8774)


uitest/src/main/java/com/vaadin/tests/components/flash/FlashExpansion.java, line 36 at r1 (raw file):

        addComponent(player);
        Button button = new Button("click");
        button.addClickListener(new Button.ClickListener() {

(this could use a lambda, but not a blocker)


Comments from Reviewable

@OlliTietavainenVaadin
Copy link
Member Author

Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions.


client/src/main/java/com/vaadin/client/ui/VFlash.java, line 146 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…

(could already fill this as 7.7.8 as it looks almost certain the 7.7 fix will be released in it)

Done.


client/src/main/java/com/vaadin/client/ui/flash/FlashConnector.java, line 2 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…

should still be 2016, I think (we'll later make a more global update for 2017 in the context of #8774)

Done.


uitest/src/main/java/com/vaadin/tests/components/flash/FlashExpansion.java, line 36 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…

(this could use a lambda, but not a blocker)

Done.


Comments from Reviewable

@hesara
Copy link
Contributor

hesara commented Mar 22, 2017

:lgtm:


Reviewed 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@hesara hesara merged commit d01a6ef into vaadin:master Mar 22, 2017
pleku pushed a commit that referenced this pull request Mar 22, 2017
Allows Flash embed to expand if percentage dimensions given

Fixes #4035
hesara pushed a commit that referenced this pull request Mar 22, 2017
Allows Flash embed to expand if percentage dimensions given

Fixes #4035
@pleku pleku added this to the 8.0.4 milestone Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants