-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V8 bugfix/4035 #8898
V8 bugfix/4035 #8898
Conversation
…imensions given
… custom calc code
Reviewed 3 of 4 files at r1. client/src/main/java/com/vaadin/client/ui/VFlash.java, line 146 at r1 (raw file):
(could already fill this as 7.7.8 as it looks almost certain the 7.7 fix will be released in it) client/src/main/java/com/vaadin/client/ui/flash/FlashConnector.java, line 2 at r1 (raw file):
should still be 2016, I think (we'll later make a more global update for 2017 in the context of #8774) uitest/src/main/java/com/vaadin/tests/components/flash/FlashExpansion.java, line 36 at r1 (raw file):
(this could use a lambda, but not a blocker) Comments from Reviewable |
Review status: 1 of 4 files reviewed at latest revision, 3 unresolved discussions. client/src/main/java/com/vaadin/client/ui/VFlash.java, line 146 at r1 (raw file): Previously, hesara (Henri Sara) wrote…
Done. client/src/main/java/com/vaadin/client/ui/flash/FlashConnector.java, line 2 at r1 (raw file): Previously, hesara (Henri Sara) wrote…
Done. uitest/src/main/java/com/vaadin/tests/components/flash/FlashExpansion.java, line 36 at r1 (raw file): Previously, hesara (Henri Sara) wrote…
Done. Comments from Reviewable |
Reviewed 3 of 3 files at r2. Comments from Reviewable |
Allows Flash embed to expand if percentage dimensions given Fixes #4035
Allows Flash embed to expand if percentage dimensions given Fixes #4035
Fixes #4035 Flash expansion
This change is