Load the debug window implementation asynchronously #9026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legioth
force-pushed
the
lazy_debug_window
branch
2 times, most recently
from
18c9a6f
to
e3b7d4a
Compare
Reduces the gzipped DefaultWidgetset eager bundle size from 345kb to 325kb. The relative impact is greater optimized widgetsets that might have down to around 150kb in the eager bundle.
Legioth
force-pushed
the
lazy_debug_window
branch
from
e3b7d4a
to
6456948
Compare
|
Works for me, and WS size really is shrinked for about 20kB. @tsuoanttila or @hesara, please have the final look and then we can merge this Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Looks ok also with respect to log messages at initialization time etc. Reviewed 1 of 1 files at r1. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the gzipped DefaultWidgetset eager bundle size from 345kb to
325kb. The relative impact is greater for optimized widgetsets that might
have down to around 150kb in the eager bundle.
This change is