Refactor common methods in in-memory data providers

[ahie]

This change is 

[pleku]

Reviewed 4 of 5 files at r1.
Review status: 4 of 5 files reviewed at latest revision, 2 unresolved discussions.

---

a discussion (no related file):
Pending javadocs and discussed renames to TreeData, TreeDataProvider, and BackEndTreeDataProvider

---

server/src/main/java/com/vaadin/data/provider/InMemoryHierarchicalDataProvider.java, line 31 at r1 (raw file):

 * A {@link DataProvider} for in-memory hierarchical data.
 *
 * @see HierarchyData

either this is removed or clarified why you should see this

---

Comments from Reviewable

[pleku]

Reviewed 26 of 27 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 12 unresolved discussions.

---

a discussion (no related file):

Previously, pleku (Pekka Hyvönen) wrote…

Pending javadocs and discussed renames to TreeData, TreeDataProvider, and BackEndTreeDataProvider

Also pending a full search for string hierarchyData and there should be 0 results from the whole project (test classed can be ignored but not javadocs.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 29 at r3 (raw file):

/**
 * TODO

TODO

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 44 at r3 (raw file):

     * @return TODO
     * @throws IllegalStateException
     *             if TODO

TODO

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 61 at r3 (raw file):

     *            TODO
     * @param childItemProvider
     *            TODO

TODO

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 91 at r3 (raw file):

HierarchyData

TreeData

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 127 at r3 (raw file):

HierarchyData

TreeData

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 162 at r3 (raw file):

HierarchyData

TreeData

---

server/src/main/java/com/vaadin/data/provider/TreeDataProvider.java, line 29 at r3 (raw file):

• {@link HierarchicalDataProvider} wrapper for {@link TreeData}.

This says absolutely nothing about why/when it is used. And the what is also pretty horrible "FOO wrapper for BAR"

---

server/src/main/java/com/vaadin/data/provider/TreeDataProvider.java, line 54 at r3 (raw file):

hierarchyData
* the backing HierarchyData

TreeData

---

server/src/test/java/com/vaadin/tests/components/TreeTest.java, line 56 at r3 (raw file):

hierarchyData

---

server/src/test/java/com/vaadin/tests/components/treegrid/TreeGridTest.java, line 28 at r3 (raw file):

hierarchyData

---

uitest/src/main/java/com/vaadin/tests/components/treegrid/TreeGridChangingHierarchy.java, line 23 at r3 (raw file):

hierarchyData

---

Comments from Reviewable

[ahie]

Review status: 20 of 27 files reviewed at latest revision, 13 unresolved discussions.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 29 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

TODO

Done.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 44 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

TODO

Done.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 61 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

TODO

Done.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 91 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

HierarchyData

TreeData

Done.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 127 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

HierarchyData

TreeData

Done.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 162 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

HierarchyData

TreeData

Done.

---

server/src/main/java/com/vaadin/data/provider/TreeDataProvider.java, line 31 at r1 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

either this is removed or clarified why you should see this

These have also been changed in #9287.

---

server/src/main/java/com/vaadin/data/provider/TreeDataProvider.java, line 54 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

hierarchyData
* the backing HierarchyData

TreeData

Done.

---

server/src/test/java/com/vaadin/tests/components/TreeTest.java, line 56 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

hierarchyData

Done.

---

server/src/test/java/com/vaadin/tests/components/treegrid/TreeGridTest.java, line 28 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

hierarchyData

Done.

---

uitest/src/main/java/com/vaadin/tests/components/treegrid/TreeGridChangingHierarchy.java, line 23 at r3 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

hierarchyData

Done.

---

Comments from Reviewable

[pleku]

Reviewed 2 of 27 files at r2, 7 of 7 files at r4.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 43 at r4 (raw file):

     * TODO
     *
     * @return TODO

TODO

---

Comments from Reviewable

[ahie]

Review status: 26 of 27 files reviewed at latest revision, 3 unresolved discussions.

---

server/src/main/java/com/vaadin/data/HasHierarchicalDataProvider.java, line 43 at r4 (raw file):

Previously, pleku (Pekka Hyvönen) wrote…

TODO

Done.

---

Comments from Reviewable

[hesara]

Reviewed 3 of 6 files at r1, 20 of 27 files at r2, 7 of 7 files at r4.
Review status: 26 of 27 files reviewed at latest revision, 6 unresolved discussions.

---

server/src/main/java/com/vaadin/data/provider/InMemoryDataProvider.java, line 47 at r4 (raw file):

    /**
     *

javadoc missing

---

server/src/main/java/com/vaadin/data/provider/InMemoryDataProvider.java, line 186 at r4 (raw file):

    /**
     *

javadoc missing

---

server/src/main/java/com/vaadin/data/provider/InMemoryDataProviderHelpers.java, line 35 at r1 (raw file):

 * @since 8.1
 */
class InMemoryDataProviderHelpers {

Should we make this more public, with javadoc still specifying "for internal use"? It might help some users.

---

Comments from Reviewable

[ahie]

Review status: 26 of 27 files reviewed at latest revision, 6 unresolved discussions.

---

server/src/main/java/com/vaadin/data/provider/InMemoryDataProvider.java, line 47 at r4 (raw file):

Previously, hesara (Henri Sara) wrote…

javadoc missing

Done.

---

server/src/main/java/com/vaadin/data/provider/InMemoryDataProvider.java, line 186 at r4 (raw file):

Previously, hesara (Henri Sara) wrote…

javadoc missing

Done.

---

server/src/main/java/com/vaadin/data/provider/InMemoryDataProviderHelpers.java, line 35 at r1 (raw file):

Previously, hesara (Henri Sara) wrote…

Should we make this more public, with javadoc still specifying "for internal use"? It might help some users.

Done.

---

Comments from Reviewable

[pleku]

Reviewed 1 of 1 files at r5, 2 of 2 files at r6.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable