-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented minimal set of OSGi bundles #9489
Conversation
Going to need a second opinion from someone who knows a bit more on this, but looks ok for me when a couple of typos are fixed. Reviewed 1 of 1 files at r1. documentation/advanced/advanced-osgi.asciidoc, line 39 at r1 (raw file):
documentation/advanced/advanced-osgi.asciidoc, line 172 at r1 (raw file):
documentation/advanced/advanced-osgi.asciidoc, line 172 at r1 (raw file):
Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions. documentation/advanced/advanced-osgi.asciidoc, line 39 at r1 (raw file): Previously, tsuoanttila (Teemu Suo-Anttila) wrote…
Done. documentation/advanced/advanced-osgi.asciidoc, line 172 at r1 (raw file): Previously, tsuoanttila (Teemu Suo-Anttila) wrote…
Done. Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions. documentation/advanced/advanced-osgi.asciidoc, line 172 at r1 (raw file): Previously, tsuoanttila (Teemu Suo-Anttila) wrote…
Done. Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions. documentation/advanced/advanced-osgi.asciidoc, line 22 at r2 (raw file):
be packaged; ... have a proper OSGi manifest ... documentation/advanced/advanced-osgi.asciidoc, line 23 at r2 (raw file):
... into a valid OSGi bundle consist of five steps: documentation/advanced/advanced-osgi.asciidoc, line 30 at r2 (raw file):
"For change scope" -> "Change the scope" ? documentation/advanced/advanced-osgi.asciidoc, line 161 at r2 (raw file):
parts -> bundles? Comments from Reviewable |
Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions. documentation/advanced/advanced-osgi.asciidoc, line 22 at r2 (raw file): Previously, hesara (Henri Sara) wrote…
Done. documentation/advanced/advanced-osgi.asciidoc, line 23 at r2 (raw file): Previously, hesara (Henri Sara) wrote…
Done. documentation/advanced/advanced-osgi.asciidoc, line 30 at r2 (raw file): Previously, hesara (Henri Sara) wrote…
Done. documentation/advanced/advanced-osgi.asciidoc, line 161 at r2 (raw file): Previously, hesara (Henri Sara) wrote…
Done. Comments from Reviewable |
- @tsuoanttila to remove his blockers Reviewed 1 of 1 files at r3. Comments from Reviewable |
Fixes #9383
This change is