Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented minimal set of OSGi bundles #9489

Merged
merged 4 commits into from
Jul 26, 2017
Merged

Documented minimal set of OSGi bundles #9489

merged 4 commits into from
Jul 26, 2017

Conversation

elmot
Copy link
Contributor

@elmot elmot commented Jun 6, 2017

Fixes #9383


This change is Reviewable

@elmot elmot requested a review from hesara June 7, 2017 14:08
@tsuoanttila
Copy link
Contributor

Going to need a second opinion from someone who knows a bit more on this, but looks ok for me when a couple of typos are fixed.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


documentation/advanced/advanced-osgi.asciidoc, line 39 at r1 (raw file):

osgi
OSGi


documentation/advanced/advanced-osgi.asciidoc, line 172 at r1 (raw file):

ho
to


documentation/advanced/advanced-osgi.asciidoc, line 172 at r1 (raw file):

unsing
using


Comments from Reviewable

@elmot
Copy link
Contributor Author

elmot commented Jun 15, 2017

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.


documentation/advanced/advanced-osgi.asciidoc, line 39 at r1 (raw file):

Previously, tsuoanttila (Teemu Suo-Anttila) wrote…

osgi
OSGi

Done.


documentation/advanced/advanced-osgi.asciidoc, line 172 at r1 (raw file):

Previously, tsuoanttila (Teemu Suo-Anttila) wrote…

ho
to

Done.


Comments from Reviewable

@elmot
Copy link
Contributor Author

elmot commented Jun 15, 2017

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.


documentation/advanced/advanced-osgi.asciidoc, line 172 at r1 (raw file):

Previously, tsuoanttila (Teemu Suo-Anttila) wrote…

unsing
using

Done.


Comments from Reviewable

@hesara
Copy link
Contributor

hesara commented Jun 19, 2017

Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions.


documentation/advanced/advanced-osgi.asciidoc, line 22 at r2 (raw file):

[[advanced.osgi.servlet.maven]]
== Minimal Vaadin Project For OSGi
Vaadin application for OSGi should be a valid bundle, i.e. it should bepackaged as a `.jar` file, and it should have proper OSGi manifest inside.

be packaged; ... have a proper OSGi manifest ...


documentation/advanced/advanced-osgi.asciidoc, line 23 at r2 (raw file):

== Minimal Vaadin Project For OSGi
Vaadin application for OSGi should be a valid bundle, i.e. it should bepackaged as a `.jar` file, and it should have proper OSGi manifest inside.
The easiest way to convert regular maven-based Vaadin application into valid OSGi bundle contains five steps:

... into a valid OSGi bundle consist of five steps:


documentation/advanced/advanced-osgi.asciidoc, line 30 at r2 (raw file):

    <packaging>jar</packaging>
----
* For change scope for all vaadin dependencies from default to `provided`, like this:

"For change scope" -> "Change the scope" ?


documentation/advanced/advanced-osgi.asciidoc, line 161 at r2 (raw file):

== Deployment to OSGi container.

In order to have your application running under OSGi container, you need to have Vaadin framework parts deployed, and then the application bundle can be deployed and started.

parts -> bundles?


Comments from Reviewable

@elmot
Copy link
Contributor Author

elmot commented Jun 19, 2017

Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions.


documentation/advanced/advanced-osgi.asciidoc, line 22 at r2 (raw file):

Previously, hesara (Henri Sara) wrote…

be packaged; ... have a proper OSGi manifest ...

Done.


documentation/advanced/advanced-osgi.asciidoc, line 23 at r2 (raw file):

Previously, hesara (Henri Sara) wrote…

... into a valid OSGi bundle consist of five steps:

Done.


documentation/advanced/advanced-osgi.asciidoc, line 30 at r2 (raw file):

Previously, hesara (Henri Sara) wrote…

"For change scope" -> "Change the scope" ?

Done.


documentation/advanced/advanced-osgi.asciidoc, line 161 at r2 (raw file):

Previously, hesara (Henri Sara) wrote…

parts -> bundles?

Done.


Comments from Reviewable

@hesara
Copy link
Contributor

hesara commented Jul 26, 2017

:lgtm: - @tsuoanttila to remove his blockers


Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from Reviewable

@hesara hesara merged commit 78604ac into master Jul 26, 2017
@hesara hesara added this to the 8.1.1 milestone Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants