Feature #9357 - addStyleNames(...)

[appreciated]

#9357

Add the following functions to Abstract Component and the respective Interface Component:

• addStyleNames(String... styles)
• removeStyleNames(String... styles)

---

This change is 

[CLAassistant]

All committers have signed the CLA.

[tsuoanttila]

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

server/src/main/java/com/vaadin/ui/Component.java, line 181 at r1 (raw file):

     * @param styles
     *            the new style to be added to the component
     * @see #getStyleName()

Link to addStyleName for a more complete description of the feature

---

server/src/main/java/com/vaadin/ui/Component.java, line 185 at r1 (raw file):

     * @see #removeStyleName(String)
     */
    public void addStyleNames(String ... styles);

Since this is aimed for Vaadin 8, you should use Interface default methods from Java 8. This change as it is right now will break any custom implementation of Component that does not extend AbstractComponent.

---

server/src/main/java/com/vaadin/ui/Component.java, line 216 at r1 (raw file):

     * @see #addStyleName(String)
     */
    public void removeStyleNames(String ... styles);

see above comment about default method.

---

Comments from Reviewable

[appreciated]

You are right, I wasn't aware of possible custom implementations of Component.
I now added the implementations as default methods to Component.

[appreciated]

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.

---

server/src/main/java/com/vaadin/ui/Component.java, line 181 at r1 (raw file):

Previously, tsuoanttila (Teemu Suo-Anttila) wrote…

Link to addStyleName for a more complete description of the feature

Done.

---

server/src/main/java/com/vaadin/ui/Component.java, line 185 at r1 (raw file):

Previously, tsuoanttila (Teemu Suo-Anttila) wrote…

Since this is aimed for Vaadin 8, you should use Interface default methods from Java 8. This change as it is right now will break any custom implementation of Component that does not extend AbstractComponent.

Done.

---

server/src/main/java/com/vaadin/ui/Component.java, line 216 at r1 (raw file):

Previously, tsuoanttila (Teemu Suo-Anttila) wrote…

see above comment about default method.

Done.

---

Comments from Reviewable

[hesara]

- dismissed Teemu's addressed review comments as he is on vacation

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

Comments from Reviewable

[elmot]

---

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

Comments from Reviewable