Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PiT 24.4: should not deprecate the dance and clean-frontend goal #2045

Closed
Tracked by #5012
ZheSun88 opened this issue Feb 7, 2024 · 2 comments · Fixed by #2123
Closed
Tracked by #5012

PiT 24.4: should not deprecate the dance and clean-frontend goal #2045

ZheSun88 opened this issue Feb 7, 2024 · 2 comments · Fixed by #2123
Labels
prerelease version for Hilla 24.4.0 Released with Hilla 24.4.0.alpha7

Comments

@ZheSun88
Copy link
Contributor

ZheSun88 commented Feb 7, 2024

with Vaadin 24.4.0.alpha3, when running mvn vaadin:dance/clean-frontent , i can see a warning about

[INFO] --- vaadin:24.4.0.alpha3:dance (default-cli) @ docs ---
[WARNING]  Goal 'dance' is deprecated: No reason given

or

[INFO] --- vaadin:24.4.0.alpha3:clean-frontend (default-cli) @ docs ---
[WARNING]  Goal 'clean-frontend' is deprecated: No reason given

this should not be deprecated.
@ZheSun88
Copy link
Contributor Author

ZheSun88 commented Feb 7, 2024

this deprecation is from hilla-maven-plugin

@ZheSun88 ZheSun88 mentioned this issue Feb 7, 2024
Open
manolo added a commit that referenced this issue Feb 27, 2024
@manolo
feat: add missing flow goals, and remove deprecations
62dd372 
Fixes: #2045 #2121
@manolo manolo mentioned this issue Feb 27, 2024
Merged
taefi pushed a commit that referenced this issue Feb 27, 2024
@manolo @cromoteca
feat: add missing flow goals, and remove deprecations (#2123)
f73d283 
* feat: add missing flow goals, and remove deprecations

Fixes: #2045 #2121

* chore: apply formatter changes

---------

Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
@manolo manolo changed the title [PIT] should not deprecate the dance and clean-frontend goal PiT 24.4: should not deprecate the dance and clean-frontend goal Feb 28, 2024
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha7 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prerelease version for Hilla 24.4.0 Released with Hilla 24.4.0.alpha7
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add missing flow goals, and remove deprecations vaadin/hilla
2 participants
@vaadin-bot @ZheSun88