fix: Avoid using decorators #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
field decorators are currently problematic when projects can use useDefineForClassFields true or false
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 51 51
Lines 3411 3411
Branches 496 496
=======================================
Hits 3241 3241
Misses 140 140
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Lodin
requested changes
Dec 13, 2023
...ges/java/hilla-dev-mode/src/main/resources/META-INF/resources/frontend/dev-tools-database.ts
Outdated
Show resolved
Hide resolved
Lodin
approved these changes
Dec 13, 2023
|
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
Artur-
pushed a commit
that referenced
this pull request
Dec 14, 2023
fix: Avoid using decorators (#1891)
|
This ticket/PR has been released with Hilla 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
field decorators are currently problematic when projects can use useDefineForClassFields true or false