Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose submitting state #1924

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Conversation

sissbruecker
Copy link
Contributor

Fixes #1164

Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad9192b) 95.26% compared to head (3be7090) 95.26%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1924   +/-   ##
=======================================
  Coverage   95.26%   95.26%           
=======================================
  Files          52       52           
  Lines        3445     3445           
  Branches      501      501           
=======================================
  Hits         3282     3282           
  Misses        136      136           
  Partials       27       27           
Flag Coverage Δ
unittests 95.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sissbruecker sissbruecker merged commit 6975ba6 into main Dec 21, 2023
15 checks passed
@sissbruecker sissbruecker deleted the fix/react-form-submitting-state branch December 21, 2023 10:12
vaadin-bot pushed a commit that referenced this pull request Dec 21, 2023
sissbruecker added a commit that referenced this pull request Dec 21, 2023
fix: expose submitting state (#1924)

Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React Form Binder: the submitting property missing in the BinderNodeControls type
4 participants