feat: add customizable form header to auto crud #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1930 +/- ##
=======================================
Coverage 95.24% 95.25%
=======================================
Files 52 52
Lines 3469 3474 +5
Branches 514 519 +5
=======================================
+ Hits 3304 3309 +5
Misses 134 134
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
requested changes
Dec 22, 2023
krissvaa
force-pushed
the
feat/auto-crud-form-header
branch
from
205bba5
to
193f41e
Compare
|
taefi
approved these changes
Jan 3, 2024
krissvaa
added a commit
that referenced
this pull request
Jan 3, 2024
krissvaa
added a commit
that referenced
this pull request
Jan 3, 2024
taefi
pushed a commit
that referenced
this pull request
Jan 3, 2024
Export type for AutoCrudForm headerRender follow up for #1930
|
This ticket/PR has been released with Hilla 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a customizable header above the form in
AutoCrud. By default it showsNew itemandCreate itemdepending on whether a new item is created or an existing one edited. It's also possible to customize the header by providing a function that renders a custom JSX element based on the edited item and the disabled state of the form. The header is part of theAutoCrudfor now instead of theAutoForm. Otherwise it would have been a challenge to move it into the header of the dialog that shows up on smaller screens.Disabled:
Editing:
Creating:
Fixes: #1664