Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add better names for autogrid filter comparison date/time options #1945

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

krissvaa
Copy link
Contributor

@krissvaa krissvaa commented Jan 8, 2024

Add better names for Autogrid filter comparison date/time options

Number type filter:
image

Date/time type filter:
image

Fixes #1505

@krissvaa krissvaa requested a review from taefi January 8, 2024 14:22
Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e0b7f0c) 95.20% compared to head (e9a8c5b) 95.20%.

Files Patch % Lines
packages/ts/react-crud/src/header-filter.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1945   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          52       52           
  Lines        3481     3483    +2     
  Branches      520      522    +2     
=======================================
+ Hits         3314     3316    +2     
  Misses        135      135           
  Partials       32       32           
Flag Coverage Δ
unittests 95.20% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@taefi taefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krissvaa krissvaa merged commit 99b72a7 into main Jan 8, 2024
14 of 15 checks passed
@krissvaa krissvaa deleted the feat/autogrid-header-comparison branch January 8, 2024 15:02
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Hilla 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autogrid][dx] Matching method for Date column's header filter should be named "Before" and "After"
3 participants