feat: extract and combine routes from fs routing and flow #2032
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
=======================================
Coverage 95.30% 95.30%
=======================================
Files 52 52
Lines 3495 3495
Branches 527 527
=======================================
Hits 3331 3331
Misses 129 129
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ava/endpoint/src/main/java/com/vaadin/hilla/route/RouteUnifyingIndexHtmlRequestListener.java
Outdated
Show resolved
Hide resolved
*Find and extract all server/client side routes and add and expose them in dev mode.
krissvaa
force-pushed
the
feat/java-file-router
branch
from
57ef156
to
4bf72c5
Compare
|
| final String viewsJson = mapper | ||
| .writeValueAsString(availableViews); | ||
| response.getDocument().head().appendElement("script") | ||
| .text("window.Vaadin.views = " + viewsJson); |
There was a problem hiding this comment.
This could lead to problems with some JSON. Jsoup has the DataNode to avoid problems, but I don't know if Jackson provides something similar. If Jsoup is on the classpath, this is how we did it in the SSO Kit: https://github.com/vaadin/sso-kit/blob/2ec9ce0308a14cbb5ad40dd6b38414a4f0b0d6f7/sso-kit-starter-hilla/src/main/java/com/vaadin/hilla/sso/starter/BootstrapDataServiceListener.java#L43-L48
|
This ticket/PR has been released with Hilla 24.4.0.alpha3 and is also targeting the upcoming stable 24.4.0 version. |
No description provided.