fix!: generate and load openapi.json to/from build dir root in dev mode #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
hilla-openapi-in-build
branch
from
ccfa683
to
b7850aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2163 +/- ##
=======================================
Coverage 93.78% 93.78%
=======================================
Files 64 64
Lines 1624 1624
Branches 365 365
=======================================
Hits 1523 1523
Misses 66 66
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* This moves the location of generating and loading openapi.json file to the root of build dir in dev mode to prevent unwanted restarts being triggered by Spring devtools. * In production mode, however, the openapi.json is generated to and loaded from the root of the classes dir to keep it available for the runtime to load it as a resource. Fixes #842
taefi
changed the title
cromoteca
approved these changes
Mar 13, 2024
|
|
This ticket/PR has been released with Hilla 24.4.0.alpha14 and is also targeting the upcoming stable 24.4.0 version. |
cromoteca
pushed a commit
that referenced
this pull request
Mar 14, 2024
…de (#2163) * fix: Put hilla-openapi.json outside classes Fixes #842 * fix!: generate and load openapi.json to/from build dir root in dev mode * This moves the location of generating and loading openapi.json file to the root of build dir in dev mode to prevent unwanted restarts being triggered by Spring devtools. * In production mode, however, the openapi.json is generated to and loaded from the root of the classes dir to keep it available for the runtime to load it as a resource. Fixes #842 --------- Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the location of generating and loading openapi.json file
to the root of build dir in dev mode to prevent unwanted restarts
being triggered by Spring devtools.
In production mode, however, the openapi.json is generated to and
loaded from the root of the classes dir to keep it available for the
runtime to load it as a resource.
This renames the
openapi.jsonfile tohilla-openapi.jsonand nolonger puts it under any package.
Fixes #842