feat: i18n translation request backend integration #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # packages/ts/react-i18n/package.json
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2168 +/- ##
=======================================
Coverage 93.77% 93.78%
=======================================
Files 64 64
Lines 1622 1624 +2
Branches 364 365 +1
=======================================
+ Hits 1521 1523 +2
Misses 66 66
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ugur-vaadin
force-pushed
the
feat-translation-request-backend-integration
branch
from
e10709e
to
1ba2f46
Compare
ugur-vaadin
commented
Mar 6, 2024
| @@ -39,6 +39,7 @@ | |||
| "@vaadin/hilla-react-auth": "file:../../../../ts/react-auth", | |||
| "@vaadin/hilla-react-crud": "file:../../../../ts/react-crud", | |||
| "@vaadin/hilla-react-form": "file:../../../../ts/react-form", | |||
| "@vaadin/hilla-react-i18n": "file:../../../../ts/react-i18n", | |||
There was a problem hiding this comment.
Not really sure if the changes in this file is really necessary.
ugur-vaadin
commented
Mar 6, 2024
| @@ -11,6 +11,7 @@ | |||
| "@vaadin/hilla-react-auth": "file:../../../../ts/react-auth", | |||
| "@vaadin/hilla-react-crud": "file:../../../../ts/react-crud", | |||
| "@vaadin/hilla-react-form": "file:../../../../ts/react-form", | |||
| "@vaadin/hilla-react-i18n": "file:../../../../ts/react-i18n", | |||
There was a problem hiding this comment.
Not really sure if the changes in this file is really necessary.
ugur-vaadin
commented
Mar 6, 2024
| @@ -0,0 +1,20 @@ | |||
| import { i18n, translate } from '@vaadin/hilla-react-i18n'; | |||
There was a problem hiding this comment.
The package here is _views instead of just views. The reason is to align with the similar temporary changes in the other test modules.
sissbruecker
reviewed
Mar 7, 2024
packages/java/tests/spring/react-i18n/src/test/java/com/vaadin/hilla/test/BasicI18NIT.java
Outdated
Show resolved
Hide resolved
sissbruecker
reviewed
Mar 7, 2024
sissbruecker
previously approved these changes
Mar 7, 2024
packages/java/tests/spring/react-i18n/frontend/_views/BasicI18NView.tsx
Outdated
Show resolved
Hide resolved
…NView.tsx Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker
previously approved these changes
Mar 7, 2024
platosha
previously approved these changes
Mar 12, 2024
|
platosha
approved these changes
Mar 12, 2024
|
This ticket/PR has been released with Hilla 24.4.0.alpha14 and is also targeting the upcoming stable 24.4.0 version. |
cromoteca
added a commit
that referenced
this pull request
Mar 14, 2024
* add basic configuration features * change implementation to use signals * update tests * add global instance * add global translate function * remember last used language * add React integration tests * remove unnecessary eslint suppression * update package.json * use fetch-mock to mock backend calls * refactor to use private properties * add missing test coverage * update package-lock.json * fix dependency versions * feat: add backend integration for translation requests * test: use default initial configuration for the tests * test: refactor tests and wait before assertions * feat: allow configuration for filtering based on retrieved locales * refactor: add resolved language signal and remove response types * fix: apply recent fixes on test project * chore: update package json * refactor: add resolved language getter and assertions * refactor: await fetch result and make block flatter * test: use language signals to wait for the translation update * test: remove unused mock case and add test for undefined resolved language * Update packages/java/tests/spring/react-i18n/frontend/_views/BasicI18NView.tsx Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> --------- Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> Co-authored-by: Anton Platonov <platosha@gmail.com> Co-authored-by: Luciano Vernaschi <luciano@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Fixes #2103
Type of change
Checklist