feat: allow checking for i18n initialized state #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2186 +/- ##
=======================================
Coverage 93.79% 93.79%
=======================================
Files 65 65
Lines 1629 1629
Branches 366 366
=======================================
Hits 1528 1528
Misses 66 66
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ugur-vaadin
reviewed
Mar 7, 2024
ugur-vaadin
previously approved these changes
Mar 7, 2024
|
@sissbruecker Hi, there's a conflict in the code. Could you, please, rebase? |
# Conflicts: # packages/ts/react-i18n/src/index.ts
|
@platosha Sure, done |
platosha
approved these changes
Mar 15, 2024
|
|
This ticket/PR has been released with Hilla 24.4.0.alpha15 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows checking whether the I18n instance has been initialized or not, for example to show a placeholder component or loading indicator while initial translations are loading.
Fixes #2104