fix: generate views.json under frontend/generated in dev mode #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 65 65
Lines 1639 1639
Branches 368 368
=======================================
Hits 1537 1537
Misses 67 67
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
added a commit
to vaadin/flow
that referenced
this pull request
Mar 24, 2024
This passes the deployment mode to the FS Router vite plugin so that it can decide where to generate needed file at runtime. Related to: vaadin/hilla#2234
mshabarov
pushed a commit
to vaadin/flow
that referenced
this pull request
Mar 25, 2024
* feat: pass deployment mode to FS Router vite plugin This passes the deployment mode to the FS Router vite plugin so that it can decide where to generate needed file at runtime. Related to: vaadin/hilla#2234 * fix tests * formatter:format
cromoteca
approved these changes
Mar 25, 2024
|
|
This ticket/PR has been released with Hilla 24.4.0.alpha18 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the location for generating the views.json
(handled by hilla-file-router/src/vite-plugin.ts) to
frontend/generated/in dev mode. This doesn't changethe location in production mode so it can be loaded as
a resource.
In dev mode, every time the vite-plugin detects changes
in views and generates a new views.json, it sends a
'full-reload' command to the browser, so that the client
requests for index.html to cause a the listener to reload
the latest changes and to modify the response.
Fixes #2213
This PR is followed up by vaadin/flow#19025 so that the
newly added plugin option
isDevModecould beinitialized properly by the vite.generated.ts
Type of change
Checklist