Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fs-router) add console errors for duplicated paths #2259

Conversation

cromoteca
Copy link
Contributor

Console messages are generated for duplicate paths in the filesystem, like about.tsx and about/$index.tsx.

Closes #2245

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (3f90fdc) to head (4dadb00).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2259   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          65       65           
  Lines        1639     1639           
  Branches      368      368           
=======================================
  Hits         1537     1537           
  Misses         67       67           
  Partials       35       35           
Flag Coverage Δ
unittests 93.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

taefi
taefi previously approved these changes Mar 26, 2024
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cromoteca cromoteca merged commit d959da5 into main Mar 26, 2024
15 checks passed
@cromoteca cromoteca deleted the fix/2245/file-router-conflicts-between-files-and-directories-are-not-handled-correctly branch March 26, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(file router) conflicts between files and directories are not handled correctly
2 participants