fix: use order index and paths comparison to sort menu items #2309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will fix the menu item orders by interpreting ViewConfig's menu order as the natural index, so that menu items with lower order will show up on top menu items with higher order. This also will adjust sort behavior in a way that views without any defined order would be show after the menu items with defined order. Ties are resolved based on the
path
string natural comparison.Fixes #2222
Type of change
Checklist