fix(fs-router): pre-populate view titles from filenames #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2321 +/- ##
==========================================
- Coverage 95.42% 95.11% -0.32%
==========================================
Files 66 66
Lines 4415 4438 +23
Branches 634 636 +2
==========================================
+ Hits 4213 4221 +8
- Misses 161 176 +15
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…nified-in-production-mode
taefi
previously approved these changes
Apr 15, 2024
…nified-in-production-mode
Lodin
previously requested changes
Apr 16, 2024
Co-authored-by: Vlad Rindevich <vladrin@vaadin.com>
…nified-in-production-mode
|
platosha
approved these changes
Apr 16, 2024
platosha
deleted the
fix/2318/fs-router-default-view-names-are-minified-in-production-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality to pre-populate view titles from filenames. It ensures that the view titles are automatically generated based on the filenames, as otherwise doing that in production mode can lead to use minified names.
Fixes #2318.