Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-router): make empty path index resolving correctly #2342

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Apr 18, 2024

Fixes #2334

@Lodin Lodin added the hilla Issues related to Hilla label Apr 18, 2024
@Lodin Lodin requested a review from platosha April 18, 2024 14:00
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (8b372c8) to head (5dee6f2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2342      +/-   ##
==========================================
+ Coverage   95.12%   95.17%   +0.04%     
==========================================
  Files          66       66              
  Lines        4472     4497      +25     
  Branches      639      644       +5     
==========================================
+ Hits         4254     4280      +26     
  Misses        177      177              
+ Partials       41       40       -1     
Flag Coverage Δ
unittests 95.17% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! Thank you!

@platosha platosha merged commit 30f1a9f into main Apr 19, 2024
15 checks passed
@platosha platosha deleted the fix/file/index-resolution branch April 19, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PT-PiT 24.4] Could not navigate to ''
2 participants