fix: attempt initializing the clientRouteRegistry during app init #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt initializing the clientRouteRegistry from RouteUnifyingServiceInitListener, so that before any request can hit the Security Config filters, the ClientRouteRegistry is optimistically initialized. In DEV mode, this attempt can result in no actual initialization if the `file-routes.json` has not yet generated. This attempt is targeting the initialization of clientRouteRegistry during the DEV mode redeployments, so that RouteUtils::isRouteAllowed has a higher chance of dealing with an initialized registry during the DEV mode. PROD mode is not affected by this change. Fixes #2358
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2371 +/- ##
=======================================
Coverage 95.14% 95.14%
=======================================
Files 66 66
Lines 4507 4507
Branches 644 644
=======================================
Hits 4288 4288
Misses 178 178
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
platosha
approved these changes
May 3, 2024
|
|
This ticket/PR has been released with Hilla 24.4.0.beta2 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt initializing the clientRouteRegistry from
RouteUnifyingServiceInitListener, so that before
any request can hit the Security Config filters,
the ClientRouteRegistry is optimistically initialized.
In DEV mode, this attempt can result in no actual
initialization if the
file-routes.jsonhas not yetgenerated. This attempt is targeting the initialization
of clientRouteRegistry during the DEV mode
redeployments, so that RouteUtils::isRouteAllowed
has a higher chance of dealing with an initialized
registry during the DEV mode.
PROD mode is not affected by this change.
Fixes #2358
Type of change
Checklist