Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make hilla endpoint optional for plugin #2383

Merged
merged 3 commits into from
May 3, 2024

Conversation

mshabarov
Copy link
Contributor

@mshabarov mshabarov commented May 3, 2024

This is an alternative for vaadin/platform#5264 that prevents hilla-dev to include Hilla artifacts (endpoint artifact) into projects that don't use Spring and Hilla.

Fixes vaadin/platform#5260

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (c623163) to head (4b73999).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2383   +/-   ##
=======================================
  Coverage   95.18%   95.18%           
=======================================
  Files          66       66           
  Lines        4507     4507           
  Branches      644      644           
=======================================
  Hits         4290     4290           
  Misses        176      176           
  Partials       41       41           
Flag Coverage Δ
unittests 95.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Copy link

sonarcloud bot commented May 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@platosha platosha merged commit 2e03a7f into main May 3, 2024
15 checks passed
@platosha platosha deleted the optional-hilla-deps-in-plugin branch May 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move hilla-dev from vaadin to vaadin-spring-boot-starter artifact in Vaadin 24.4
2 participants