-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NumberSignal basic support #2502
base: main
Are you sure you want to change the base?
Conversation
Why is |
packages/java/endpoint/src/main/java/com/vaadin/hilla/signals/core/EventQueue.java
Outdated
Show resolved
Hide resolved
Good catch. That was unintentionally committed/pushed. Reverted. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2502 +/- ##
==========================================
- Coverage 92.56% 92.53% -0.03%
==========================================
Files 69 68 -1
Lines 2245 2238 -7
Branches 590 590
==========================================
- Hits 2078 2071 -7
Misses 120 120
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c8501a1
to
df1ee1d
Compare
|
|
Description
Add basic support for full-stack
NumberSignal
type to be returned by endpoints as a shared signal instance that supports number value operations. The client-side user code (for now) need to do manual wrapping of the needed metadata about the endpoint method(s) that return shared signal instance(s).Assuming a simple endpoint returning a
NumberSignal
instance like this:The needed manually written user code is like this (this will be generated later):
Then then usage of this wrapping service in views could be similar to what is described in the related issue:
Fixes #2429
Type of change
Checklist
Additional for
Feature
type of change